Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cache init and update timeouts in stored requests #4027

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Fix cache init and update timeouts in stored requests #4027

merged 1 commit into from
Nov 22, 2024

Conversation

linux019
Copy link
Contributor

There are redundant conversions to interval in milliseconds which duplicates the same in initialization of the config.

prebid-server/stored_requests/config/config.go

Line 208 in df58baf

CacheInitTimeout: time.Duration(cfg.Database.CacheInitialization.Timeout) * time.Millisecond,

prebid-server/stored_requests/config/config.go

Line 210 in df58baf

CacheUpdateTimeout: time.Duration(cfg.Database.PollUpdates.Timeout) * time.Millisecond,

@linux019 linux019 changed the title fix update timeouts in stored requests Fix cache init and update update timeouts in stored requests Oct 30, 2024
@linux019 linux019 changed the title Fix cache init and update update timeouts in stored requests Fix cache init and update timeouts in stored requests Oct 30, 2024
SyntaxNode
SyntaxNode approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@SyntaxNode SyntaxNode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find.

@SyntaxNode SyntaxNode self-assigned this Nov 1, 2024
@przemkaczmarek przemkaczmarek self-assigned this Nov 14, 2024
@przemkaczmarek przemkaczmarek self-requested a review November 14, 2024 13:07
@bsardo bsardo merged commit 2099424 into prebid:master Nov 22, 2024
3 checks passed
@cross-repo-issue-creation cross-repo-issue-creation bot mentioned this pull request Nov 22, 2024
Closed
@linux019 linux019 deleted the fix-timeouts-stored-requests branch November 22, 2024 06:22
scr-oath pushed a commit to scr-oath/prebid-server that referenced this pull request Dec 16, 2024
@linux019 @scr-oath
Fix cache init and update timeouts in stored requests (prebid#4027)
02c5b46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SyntaxNode SyntaxNode SyntaxNode approved these changes

@przemkaczmarek przemkaczmarek przemkaczmarek approved these changes

Assignees

@SyntaxNode SyntaxNode

@przemkaczmarek przemkaczmarek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@linux019 @SyntaxNode @przemkaczmarek @bsardo