Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rise: Update bidder info yaml #4039

Merged
merged 4 commits into from
Dec 10, 2024
Merged

Rise: Update bidder info yaml #4039

merged 4 commits into from
Dec 10, 2024

Conversation

zkosanovic
Copy link
Contributor

No description provided.

SyntaxNode
SyntaxNode reviewed Nov 5, 2024
View reviewed changes
Copy link
Contributor

@SyntaxNode SyntaxNode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you're updating the bidder info, does Rise support OpenRTB 2.6? That's another potential setting to declare in the bidder info.

@zkosanovic
Copy link
Contributor Author

@SyntaxNode as of right now, we don't support OpenRTB 2.6

@zkosanovic zkosanovic requested a review from SyntaxNode November 5, 2024 23:43
SyntaxNode
SyntaxNode reviewed Nov 6, 2024
View reviewed changes
adapters/rise/risetest/exemplary/simple-native.json Outdated
"crid": "29681110",
"h": 250,
"w": 300,
"mtype": 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mtype should be 4 for native.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, c517a3a

rise

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/rise/rise.go:23:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/rise/rise.go:30:	MakeRequests		81.8%
github.com/prebid/prebid-server/v3/adapters/rise/rise.go:56:	MakeBids		88.9%
github.com/prebid/prebid-server/v3/adapters/rise/rise.go:93:	extractOrg		100.0%
github.com/prebid/prebid-server/v3/adapters/rise/rise.go:117:	getMediaTypeForBid	100.0%
total:								(statements)		91.7%

@zkosanovic zkosanovic requested a review from SyntaxNode November 6, 2024 13:01
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 6de7ab5

rise

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/rise/rise.go:23:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/rise/rise.go:30:	MakeRequests		81.8%
github.com/prebid/prebid-server/v3/adapters/rise/rise.go:56:	MakeBids		88.9%
github.com/prebid/prebid-server/v3/adapters/rise/rise.go:93:	extractOrg		100.0%
github.com/prebid/prebid-server/v3/adapters/rise/rise.go:117:	getMediaTypeForBid	100.0%
total:								(statements)		91.7%

@SyntaxNode SyntaxNode self-assigned this Nov 20, 2024
@bsardo bsardo self-assigned this Nov 22, 2024
bsardo
bsardo reviewed Nov 22, 2024
View reviewed changes
Copy link
Collaborator

@bsardo bsardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please open up a docs PR to capture these changes and provide the link here.

@Dedis23 Dedis23 mentioned this pull request Nov 28, 2024
Merged
8 tasks
@Dedis23
Copy link
Contributor

Dedis23 commented Nov 28, 2024

Please open up a docs PR to capture these changes and provide the link here.

Here is the corresponding docs PR:
prebid/prebid.github.io#5735

thanks!

@bsardo bsardo merged commit f963cdb into prebid:master Dec 10, 2024
5 checks passed
@cross-repo-issue-creation cross-repo-issue-creation bot mentioned this pull request Dec 10, 2024
Closed
scr-oath pushed a commit to scr-oath/prebid-server that referenced this pull request Dec 16, 2024
@zkosanovic @scr-oath
Rise: Update bidder info yaml (prebid#4039)
6d7aa6c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsardo bsardo bsardo approved these changes

@SyntaxNode SyntaxNode SyntaxNode approved these changes

Assignees

@bsardo bsardo

@SyntaxNode SyntaxNode

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zkosanovic @Dedis23 @bsardo @SyntaxNode