Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EPlanning: Add schain support #4146

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

EPlanning: Add schain support #4146

wants to merge 3 commits into from

Conversation

maximilianozurita
Copy link

@maximilianozurita maximilianozurita commented Jan 9, 2025 •
edited
Loading

Type of change

  • Feature

Description of change

  • passing schain information

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 4e95b38

eplanning

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/eplanning/eplanning.go:73:	MakeRequests		93.8%
github.com/prebid/prebid-server/v3/adapters/eplanning/eplanning.go:229:	unmarshalSupplyChain	80.0%
github.com/prebid/prebid-server/v3/adapters/eplanning/eplanning.go:238:	makeSupplyChain		90.9%
github.com/prebid/prebid-server/v3/adapters/eplanning/eplanning.go:265:	makeNodeValue		71.4%
github.com/prebid/prebid-server/v3/adapters/eplanning/eplanning.go:291:	isMobileDevice		100.0%
github.com/prebid/prebid-server/v3/adapters/eplanning/eplanning.go:295:	getImpTypeRequest	100.0%
github.com/prebid/prebid-server/v3/adapters/eplanning/eplanning.go:312:	cleanName		100.0%
github.com/prebid/prebid-server/v3/adapters/eplanning/eplanning.go:319:	verifyImp		95.8%
github.com/prebid/prebid-server/v3/adapters/eplanning/eplanning.go:379:	searchSizePriority	100.0%
github.com/prebid/prebid-server/v3/adapters/eplanning/eplanning.go:388:	getSizeFromImp		100.0%
github.com/prebid/prebid-server/v3/adapters/eplanning/eplanning.go:419:	addHeaderIfNonEmpty	100.0%
github.com/prebid/prebid-server/v3/adapters/eplanning/eplanning.go:425:	MakeBids		100.0%
github.com/prebid/prebid-server/v3/adapters/eplanning/eplanning.go:496:	getBidType		100.0%
github.com/prebid/prebid-server/v3/adapters/eplanning/eplanning.go:505:	getNameVideo		100.0%
github.com/prebid/prebid-server/v3/adapters/eplanning/eplanning.go:510:	Builder			100.0%
total:									(statements)		94.1%

@bsardo bsardo changed the title EPlanning Bid Adapter: Adding support for schain EPlanning: Add schain support Jan 10, 2025
@bsardo bsardo added the adapter label Jan 10, 2025
@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 1ee929f

eplanning

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/eplanning/eplanning.go:73:	MakeRequests		94.6%
github.com/prebid/prebid-server/v3/adapters/eplanning/eplanning.go:221:	unmarshalSupplyChain	80.0%
github.com/prebid/prebid-server/v3/adapters/eplanning/eplanning.go:230:	makeSupplyChain		90.9%
github.com/prebid/prebid-server/v3/adapters/eplanning/eplanning.go:257:	makeNodeValue		71.4%
github.com/prebid/prebid-server/v3/adapters/eplanning/eplanning.go:283:	isMobileDevice		100.0%
github.com/prebid/prebid-server/v3/adapters/eplanning/eplanning.go:287:	getImpTypeRequest	100.0%
github.com/prebid/prebid-server/v3/adapters/eplanning/eplanning.go:304:	cleanName		100.0%
github.com/prebid/prebid-server/v3/adapters/eplanning/eplanning.go:311:	verifyImp		95.8%
github.com/prebid/prebid-server/v3/adapters/eplanning/eplanning.go:371:	searchSizePriority	100.0%
github.com/prebid/prebid-server/v3/adapters/eplanning/eplanning.go:380:	getSizeFromImp		100.0%
github.com/prebid/prebid-server/v3/adapters/eplanning/eplanning.go:411:	addHeaderIfNonEmpty	100.0%
github.com/prebid/prebid-server/v3/adapters/eplanning/eplanning.go:417:	MakeBids		100.0%
github.com/prebid/prebid-server/v3/adapters/eplanning/eplanning.go:488:	getBidType		100.0%
github.com/prebid/prebid-server/v3/adapters/eplanning/eplanning.go:497:	getNameVideo		100.0%
github.com/prebid/prebid-server/v3/adapters/eplanning/eplanning.go:502:	Builder			100.0%
total:									(statements)		94.4%

@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 1af0c02

eplanning

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/eplanning/eplanning.go:73:	MakeRequests		94.6%
github.com/prebid/prebid-server/v3/adapters/eplanning/eplanning.go:221:	unmarshalSupplyChain	80.0%
github.com/prebid/prebid-server/v3/adapters/eplanning/eplanning.go:230:	makeSupplyChain		90.9%
github.com/prebid/prebid-server/v3/adapters/eplanning/eplanning.go:257:	makeNodeValue		71.4%
github.com/prebid/prebid-server/v3/adapters/eplanning/eplanning.go:283:	isMobileDevice		100.0%
github.com/prebid/prebid-server/v3/adapters/eplanning/eplanning.go:287:	getImpTypeRequest	100.0%
github.com/prebid/prebid-server/v3/adapters/eplanning/eplanning.go:304:	cleanName		100.0%
github.com/prebid/prebid-server/v3/adapters/eplanning/eplanning.go:311:	verifyImp		95.8%
github.com/prebid/prebid-server/v3/adapters/eplanning/eplanning.go:371:	searchSizePriority	100.0%
github.com/prebid/prebid-server/v3/adapters/eplanning/eplanning.go:380:	getSizeFromImp		100.0%
github.com/prebid/prebid-server/v3/adapters/eplanning/eplanning.go:411:	addHeaderIfNonEmpty	100.0%
github.com/prebid/prebid-server/v3/adapters/eplanning/eplanning.go:417:	MakeBids		100.0%
github.com/prebid/prebid-server/v3/adapters/eplanning/eplanning.go:488:	getBidType		100.0%
github.com/prebid/prebid-server/v3/adapters/eplanning/eplanning.go:497:	getNameVideo		100.0%
github.com/prebid/prebid-server/v3/adapters/eplanning/eplanning.go:502:	Builder			100.0%
total:									(statements)		94.4%

hhhjort
hhhjort reviewed Jan 28, 2025
View reviewed changes
adapters/eplanning/eplanning.go
@@ -212,6 +218,68 @@ func (adapter *EPlanningAdapter) MakeRequests(request *openrtb2.BidRequest, reqI
return requests, errors
}

func unmarshalSupplyChain(req *openrtb2.BidRequest) *openrtb2.SupplyChain {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may make things clearer to just pass unmarshalSupplyChain the request.Source.Ext object rather than the whole request object. Makes it clear what unmarshalSupplyChain is actually doing and using.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hhhjort hhhjort hhhjort left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

@hhhjort hhhjort

@przemkaczmarek przemkaczmarek

Labels
adapter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maximilianozurita @hhhjort @bsardo @przemkaczmarek