Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update removeAdUnit #1138

Merged
merged 2 commits into from
Mar 2, 2019
Merged

update removeAdUnit #1138

merged 2 commits into from
Mar 2, 2019

Conversation

deekshithraop
Copy link
Contributor

@deekshithraop deekshithraop commented Feb 6, 2019 •
edited
Loading

link to PR for corresponding changes(prebid/Prebid.js#3527)

@deekshithraop deekshithraop mentioned this pull request Feb 6, 2019
Merged
1 task
@deekshithraop deekshithraop requested a review from bretg February 6, 2019 19:23
bretg
bretg approved these changes Feb 6, 2019
View reviewed changes
Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't need to update the -old doc, but no harm.

@bretg
Copy link
Contributor

bretg commented Feb 6, 2019

This looks fine from a doc perspective, but I'm curious what use case drove this?

@deekshithraop deekshithraop changed the title add removeAllAddUnits to pbjs api update removeAdUnit Feb 12, 2019
@bretg
Copy link
Contributor

bretg commented Mar 2, 2019

released with 2.4

@bretg bretg merged commit b0a6fa1 into master Mar 2, 2019
@bretg bretg deleted the removeAllAddUnits branch October 19, 2021 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bretg bretg bretg approved these changes

Assignees
No one assigned
Labels
LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deekshithraop @bretg