Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telaria: Added SupplyChain Object documentation #1458

Merged
merged 12 commits into from
Sep 27, 2019
Merged

Conversation

telariaEng
Copy link
Contributor

@telariaEng telariaEng commented Aug 30, 2019

We enhanced our adapter to handle schain objects.

tremorvideo and others added 10 commits August 1, 2018 12:36
…ubs using our adapter can login to our console to get a list of params.
made the reference to tremor a link, don't need the 1.0 note in the description -- moving to the prebid_1_0_supported flag
# Conflicts:
#	dev-docs/bidders/telaria.md
#	dev-docs/bidders/tremor.md
@bretg
Copy link
Contributor

bretg commented Sep 3, 2019

@telariaEng - we would prefer that you make use of the (new) standard way of defining schain. prebid/Prebid.js#4084

Basically, in addition to defining schain as a bidder-specific parameter, I'm suggesting you should document that your users can use setConfig and your adapter should getConfig to retrieve it.

@bretg bretg self-assigned this Sep 3, 2019
@bretg bretg added the question label Sep 3, 2019
@telariaEng
Copy link
Contributor Author

@telariaEng - we would prefer that you make use of the (new) standard way of defining schain. prebid/Prebid.js#4084

Basically, in addition to defining schain as a bidder-specific parameter, I'm suggesting you should document that your users can use setConfig and your adapter should getConfig to retrieve it.

okay sounds good. I'll update our adapter to getConfig before trying to check if the schain param is present in the params object. .

@bretg
Copy link
Contributor

bretg commented Sep 3, 2019

@telariaEng - sorry - just found out that the right way to pull the schain is illustrated by the pubmatic adapter, which is to check the bidRequest object for an schain attribute.

@telariaEng
Copy link
Contributor Author

@telariaEng - sorry - just found out that the right way to pull the schain is illustrated by the pubmatic adapter, which is to check the bidRequest object for an schain attribute.

yeah thanks I saw that. The pubs should still be using pbjs.setConfig({schain:{}) to set the schain param right?

@telariaEng
Copy link
Contributor Author

Okay I've updated the docs and will be creating a new PR for the code changes. I have enhanced the adapter to first look to see if validBidRequests has the schain and then check if its present in the params.

@bretg
Copy link
Contributor

bretg commented Sep 11, 2019

Confused about whether this feature is live or not, as it refers to two PRs -- one merged, one not.

@bretg bretg changed the title Added SupplyChain Object documentation Telaria: Added SupplyChain Object documentation Sep 27, 2019
@bretg
Copy link
Contributor

bretg commented Sep 27, 2019

released with 2.34

@bretg bretg merged commit ad9ede6 into prebid:master Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants