-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Telaria: Added SupplyChain Object documentation #1458
Conversation
…med) and updated the documentation
…ubs using our adapter can login to our console to get a list of params.
made the reference to tremor a link, don't need the 1.0 note in the description -- moving to the prebid_1_0_supported flag
# Conflicts: # dev-docs/bidders/telaria.md # dev-docs/bidders/tremor.md
Merging master to the fork
Merging the docs with master
@telariaEng - we would prefer that you make use of the (new) standard way of defining Basically, in addition to defining schain as a bidder-specific parameter, I'm suggesting you should document that your users can use |
okay sounds good. I'll update our adapter to getConfig before trying to check if the schain param is present in the params object. . |
@telariaEng - sorry - just found out that the right way to pull the schain is illustrated by the pubmatic adapter, which is to check the bidRequest object for an |
yeah thanks I saw that. The pubs should still be using pbjs.setConfig({schain:{}) to set the schain param right? |
Merged with master and updated the docs
Okay I've updated the docs and will be creating a new PR for the code changes. I have enhanced the adapter to first look to see if validBidRequests has the schain and then check if its present in the params. |
Confused about whether this feature is live or not, as it refers to two PRs -- one merged, one not. |
released with 2.34 |
We enhanced our adapter to handle schain objects.