Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Parrable ID submodule docs #1529

Merged
merged 13 commits into from
Oct 15, 2019

Conversation

icflournoy
Copy link
Contributor

Adds documentation for the forthcoming Parrable ID system submodule.

rick-parrable and others added 11 commits September 4, 2019 16:32
It's tempting to use a valid EID but if anyone were to play with it
then we could get the device id it contains mixed up with others.
With this commit, I've gone to a placeholder value that is syntatically
valid/representative but will not decrypt.
Add Parrable ID System Docs
Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a number of ID sub-modules pending -- there will almost certainly be collisions to fix by the time this is merged, but it looks ok other than needing to know how you want to appear in the OpenRTB. Search for 'eids' in the doc.

Copy link
Member

@jdwieland8282 jdwieland8282 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mind adding an example, of how prebid server adapters need to be updated if they want to consume this value. Others have used something like { "source": "parrable.com", "uids": [{ "id": "11111111" }] }

@justinegreene
Copy link

justinegreene commented Oct 9, 2019

@bretg and @jdwieland8282, Thank you for the feedback. With respect to openRTB are you referring to bidders with prebid server adapters. The snippet above appears to be from the Prebid server section of the Docs.

On a related note, we are not clear how to modify or inform prebid server to include our cookies in the openRTB object. We can certainly extend the docs, but how does prebid server know to pickup the storage that we have configured in prebid.js?

@jdwieland8282
Copy link
Member

Hey @justinegreene sorry yes I was referring to prebid server adapters, from a documentation standpoint this docs PR should describe how PB server adapters should be prepared to read your id. wrt, your question about modifying prebid server prebid/Prebid.js#4178 (comment)

@eyas-ranjous
Copy link

@bretg @jdwieland8282 all reviews addressed in this PR. please consider merging. thanks.

Copy link
Member

@jdwieland8282 jdwieland8282 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding, looks good.

@bretg
Copy link
Contributor

bretg commented Oct 15, 2019

resolved conflicts after merging liveintent. merging this now

@bretg bretg merged commit cc97ef7 into prebid:master Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants