-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Parrable ID submodule docs #1529
Conversation
Several places are incomplete and are marked with @todo
It's tempting to use a valid EID but if anyone were to play with it then we could get the device id it contains mixed up with others. With this commit, I've gone to a placeholder value that is syntatically valid/representative but will not decrypt.
Add Parrable ID System Docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a number of ID sub-modules pending -- there will almost certainly be collisions to fix by the time this is merged, but it looks ok other than needing to know how you want to appear in the OpenRTB. Search for 'eids' in the doc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mind adding an example, of how prebid server adapters need to be updated if they want to consume this value. Others have used something like { "source": "parrable.com", "uids": [{ "id": "11111111" }] }
@bretg and @jdwieland8282, Thank you for the feedback. With respect to openRTB are you referring to bidders with prebid server adapters. The snippet above appears to be from the Prebid server section of the Docs. On a related note, we are not clear how to modify or inform prebid server to include our cookies in the openRTB object. We can certainly extend the docs, but how does prebid server know to pickup the storage that we have configured in prebid.js? |
Hey @justinegreene sorry yes I was referring to prebid server adapters, from a documentation standpoint this docs PR should describe how PB server adapters should be prepared to read your id. wrt, your question about modifying prebid server prebid/Prebid.js#4178 (comment) |
@bretg @jdwieland8282 all reviews addressed in this PR. please consider merging. thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for adding, looks good.
resolved conflicts after merging liveintent. merging this now |
Adds documentation for the forthcoming Parrable ID system submodule.