-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verizon Media user id module documentation #2368
Verizon Media user id module documentation #2368
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, just need to make the name consistent with the latest change in the user ID PR
dev-docs/modules/userId.md
Outdated
@@ -58,7 +58,7 @@ of sub-objects. The table below has the options that are common across ID system | |||
{: .table .table-bordered .table-striped } | |||
| Param under userSync.userIds[] | Scope | Type | Description | Example | | |||
| --- | --- | --- | --- | --- | | |||
| name | Required | String | May be: `"britepoolId"`, `"criteo"`, `"haloId"`, `"id5id"`, `identityLink`, `"intentIqId"`, `"liveIntentId"`, `"lotamePanoramaId"`, `"merkleId"`, `"netId"`, `"parrableId"`, `"quantcastId"`, `"pubCommonId"`, `"sharedId"`, `"unifiedId"`, `"zeotapIdPlus"` | `"unifiedId"` | | |||
| name | Required | String | May be: `"britepoolId"`, `"criteo"`, `"haloId"`, `"id5id"`, `identityLink`, `"intentIqId"`, `"liveIntentId"`, `"lotamePanoramaId"`, `"merkleId"`, `"netId"`, `"parrableId"`, `"quantcastId"`, `"pubCommonId"`, `"sharedId"`, `"unifiedId"`, `"verizonMedia"`, `"zeotapIdPlus"` | `"unifiedId"` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be verizonMediaId
I think
| name | Required | String | May be: `"britepoolId"`, `"criteo"`, `"haloId"`, `"id5id"`, `identityLink`, `"intentIqId"`, `"liveIntentId"`, `"lotamePanoramaId"`, `"merkleId"`, `"netId"`, `"parrableId"`, `"quantcastId"`, `"pubCommonId"`, `"sharedId"`, `"unifiedId"`, `"verizonMedia"`, `"zeotapIdPlus"` | `"unifiedId"` | | |
| name | Required | String | May be: `"britepoolId"`, `"criteo"`, `"haloId"`, `"id5id"`, `identityLink`, `"intentIqId"`, `"liveIntentId"`, `"lotamePanoramaId"`, `"merkleId"`, `"netId"`, `"parrableId"`, `"quantcastId"`, `"pubCommonId"`, `"sharedId"`, `"unifiedId"`, `"verizonMediaId"`, `"zeotapIdPlus"` | `"unifiedId"` | |
dev-docs/modules/userId.md
Outdated
{: .table .table-bordered .table-striped } | ||
| Param under userSync.userIds[] | Scope | Type | Description | Example | | ||
| --- | --- | --- | --- | --- | | ||
| name | Required | String | The name of this module. | `'verizonMedia'` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be verizonMediaId
| name | Required | String | The name of this module. | `'verizonMedia'` | | |
| name | Required | String | The name of this module. | `'verizonMediaId'` | |
dev-docs/modules/userId.md
Outdated
@@ -971,6 +1021,7 @@ Bidders that want to support the User ID module in Prebid.js, need to update the | |||
| Quantcast ID | n/a | bidRequest.userId.quantcastId | `"1111"` | | |||
| Shared ID | SharedId | bidRequest.userId.sharedid | `{"id":"01EAJWWNEPN3CYMM5N8M5VXY22","third":"01EAJWWNEPN3CYMM5N8M5VXY22"}` | | |||
| Unified ID | Trade Desk | bidRequest.userId.tdid | `"1111"` | | |||
| Verizon Media ID | Verizon Media | bidRequest.userId.vmuid | `72d04af6e07c2eb93e9c584a131f48b6a9b963bcb2736d624e987ff8cf36d472` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the value should be a string
| Verizon Media ID | Verizon Media | bidRequest.userId.vmuid | `72d04af6e07c2eb93e9c584a131f48b6a9b963bcb2736d624e987ff8cf36d472` | | |
| Verizon Media ID | Verizon Media | bidRequest.userId.vmuid | `"72d04af6e07c2eb93e9c584a131f48b6a9b963bcb2736d624e987ff8cf36d472"` | |
dev-docs/modules/userId.md
Outdated
pbjs.setConfig({ | ||
userSync: { | ||
userIds: [{ | ||
name: "verizonMedia", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name: "verizonMedia", | |
name: "verizonMediaId", |
this commit needs to include a change to download.md |
…nto feature/verizonmedia-user-id-docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mind making the list of modules alphabetical?
dev-docs/modules/userId.md
Outdated
@@ -58,7 +58,7 @@ of sub-objects. The table below has the options that are common across ID system | |||
{: .table .table-bordered .table-striped } | |||
| Param under userSync.userIds[] | Scope | Type | Description | Example | | |||
| --- | --- | --- | --- | --- | | |||
| name | Required | String | May be: `"britepoolId"`, `"criteo"`, `"haloId"`, `"id5id"`, `identityLink`, `"intentIqId"`, `"liveIntentId"`, `"lotamePanoramaId"`, `"merkleId"`, `"netId"`, `"parrableId"`, `"quantcastId"`, `"pubCommonId"`, `"sharedId"`, `"unifiedId"`, `"verizonMediaId"`, `"zeotapIdPlus"` | `"unifiedId"` | | |||
| name | Required | String | May be: `"britepoolId"`, `"criteo"`, `"fabrickId"`, `"haloId"`, `"id5id"`, `identityLink`, `"idx"`, `"intentIqId"`, `"liveIntentId"`, `"lotamePanoramaId"`, `"merkleId"`, `"netId"`, `"parrableId"`, `"quantcastId"`, `"pubCommonId"`, `"pubProvidedId"`, `"sharedId"`, `"unifiedId"`, `"zeotapIdPlus"`, `"verizonMediaId"` | `"unifiedId"` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This list is meant to be alphabetical.
@@ -58,7 +58,7 @@ of sub-objects. The table below has the options that are common across ID system | |||
{: .table .table-bordered .table-striped } | |||
| Param under userSync.userIds[] | Scope | Type | Description | Example | | |||
| --- | --- | --- | --- | --- | | |||
| name | Required | String | May be: `"britepoolId"`, `"criteo"`, `"fabrickId"`, `"haloId"`, `"id5id"`, `identityLink`, `"idx"`, `"intentIqId"`, `"liveIntentId"`, `"lotamePanoramaId"`, `"merkleId"`, `"netId"`, `"parrableId"`, `"quantcastId"`, `"pubCommonId"`, `"pubProvidedId"`, `"sharedId"`, `"unifiedId"`, `"zeotapIdPlus"`, `"verizonMediaId"` | `"unifiedId"` | | |||
| name | Required | String | May be: `"britepoolId"`, `"criteo"`, `"fabrickId"`, `"haloId"`, `"id5id"`, `identityLink`, `"idx"`, `"intentIqId"`, `"liveIntentId"`, `"lotamePanoramaId"`, `"merkleId"`, `"netId"`, `"parrableId"`, `"quantcastId"`, `"pubCommonId"`, `"pubProvidedId"`, `"sharedId"`, `"unifiedId"`, `"verizonMediaId"`, `"zeotapIdPlus"` | `"unifiedId"` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
zeotapidplus should be last
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jdwieland8282 - Correct me if I'm wrong, but it is last. "unifiedId"
is in the example column as it always has been.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry you are correct @slimkrazy my bad, I was reading the md incorrectly
@jdwieland8282 - Seems that master moved along after my PR. I've resolved the conflict now. The new user ID module was released in the last version of Prebid - getting these docs out soon would really help. Thanks. |
Thanks for the reminder @slimkrazy this is supposed to happen immediately after the release. I'll merge them in now. |
No description provided.