Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Qwarry bid adapter #2380

Merged
merged 4 commits into from
Oct 14, 2020
Merged

Add Qwarry bid adapter #2380

merged 4 commits into from
Oct 14, 2020

Conversation

pro-nsk
Copy link
Contributor

@pro-nsk pro-nsk commented Sep 29, 2020

No description provided.

@pro-nsk pro-nsk mentioned this pull request Sep 29, 2020
10 tasks
@musikele
Copy link
Contributor

adapter merged, at next release doc can be merged too.

Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add the "pbjs: true" header entry or this file won't appear

And any other fields you'd like to declare as noted in https://docs.prebid.org/dev-docs/bidder-adaptor.html#submitting-your-adapter (e.g. gdpr_supported, etc.)

@pro-nsk
Copy link
Contributor Author

pro-nsk commented Oct 9, 2020

please add the "pbjs: true" header entry or this file won't appear

And any other fields you'd like to declare as noted in https://docs.prebid.org/dev-docs/bidder-adaptor.html#submitting-your-adapter (e.g. gdpr_supported, etc.)

Hello. Fixed

Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry - also just noticed that the example string parameter needs quotes.

'8a80d8e9-0cf9-4329-8486-6f5bbcd8a61a'

instead of

8a80d8e9-0cf9-4329-8486-6f5bbcd8a61a

@pro-nsk
Copy link
Contributor Author

pro-nsk commented Oct 10, 2020

Sorry - also just noticed that the example string parameter needs quotes.

'8a80d8e9-0cf9-4329-8486-6f5bbcd8a61a'

instead of

8a80d8e9-0cf9-4329-8486-6f5bbcd8a61a

Fixed

@xylo2
Copy link

xylo2 commented Oct 12, 2020

Hi @bretg ,
Is everything good, now ?
Thanks

@pro-nsk pro-nsk requested a review from bretg October 14, 2020 10:04
@bretg
Copy link
Contributor

bretg commented Oct 14, 2020

went out with 4.11. merging.

@bretg bretg merged commit c91ff37 into prebid:master Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants