Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add IDx User Id docs #2408

Merged
merged 4 commits into from
Oct 14, 2020
Merged

add IDx User Id docs #2408

merged 4 commits into from
Oct 14, 2020

Conversation

rtoscani
Copy link
Contributor

@rtoscani rtoscani commented Oct 8, 2020

Added IDx documentation for User ID. prebid/Prebid.js#5826

@jdwieland8282
Copy link
Member

@rtoscani please add an entry to download.md

@rtoscani
Copy link
Contributor Author

rtoscani commented Oct 8, 2020

@jdwieland8282 done

@jdwieland8282
Copy link
Member

jdwieland8282 commented Oct 8, 2020

Hi @rtoscani I'm not getting a cookie (or LS value) when I build your branch. I do see a sharedid cookie though.

         "userSync":{
            "userIds":[{
                  name: 'sharedId',
                  params: {
                            syncTime: 60 // in seconds, default is 24 hours
                   },
                  storage: {
                      name: 'sharedid',
                      type: 'html5',
                      expires: 28
                  },
              },
              {
                name:'idx'
              }]
         }
      });

@rtoscani
Copy link
Contributor Author

rtoscani commented Oct 9, 2020

Hi @jdwieland8282, we do not generate the IDx from prebid right now (only reading existing IDx is implemented in prebid), the only way of generating a cookie is using our tag (and it's on beta right now). We are making a lot of changes in our API, in the next PR you will be able to generate and use an IDx from prebid.

@jdwieland8282
Copy link
Member

I see thanks for clarifying. You may want to add that to your documentation, but it's up to you.

Copy link
Member

@jdwieland8282 jdwieland8282 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noted that the module only reads cookies that exist and does not create news ones. I've suggested this distinction be added to the documentation but am not requiring it.

@bretg bretg mentioned this pull request Oct 14, 2020
9 tasks
@bretg
Copy link
Contributor

bretg commented Oct 14, 2020

part of 4.12

@bretg bretg merged commit ca1aa4d into prebid:master Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants