Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nobid: Support tcf2 and pbs #2452

Merged
merged 8 commits into from
Nov 3, 2020
Merged

Conversation

redaguermas
Copy link
Contributor

Adde support for TCF2.0 and Prebid Server

@SyntaxNode
Copy link
Contributor

Looking good. Thank you for keeping the siteId and placementId parameters consistent between PBJS and PBS. I looks like PBS doesn't support the video parameter. Could you please make a note of that in this doc update?

@redaguermas
Copy link
Contributor Author

@SyntaxNode please check the PR

@bretg bretg changed the title Support tcf2 and pbs Nobid: Support tcf2 and pbs Oct 29, 2020
dev-docs/bidders/nobidBidAdapter.md Outdated Show resolved Hide resolved
@redaguermas
Copy link
Contributor Author

@bretg Can you please merge this documentation PR. It's blocking the PBS release as well as the PBJS release for Extended IDs.
Regards

@bretg
Copy link
Contributor

bretg commented Nov 3, 2020

We don't generally merge docs PRs until the Prebid.js release goes out. So this isn't blocking that merge.

In this case, I'll go ahead and merge it because PBS is on a different schedule.

@bretg bretg merged commit 63f1841 into prebid:master Nov 3, 2020
@SyntaxNode
Copy link
Contributor

SyntaxNode commented Nov 4, 2020

We don't generally merge docs PRs until the Prebid.js release goes out. So this isn't blocking that merge.

In this case, I'll go ahead and merge it because PBS is on a different schedule.

To be clear, this wasn't blocking your PBS PR. We require a documentation PR to be opened and in good standing (LGTM label) before being merged in. Those were both met in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants