Add use case description for pbadslot and bidder flags #2928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gglas did you have pending feedback here? |
|
@gglas this pr is growing out of date awaiting your feedback |
|
My issue here is that I'm not convinced pbadslot is what's desired by the DSPs. My understanding is that GAM adslot is what they want. Those things can differ. I'm not fond of doing anything ad server specific, but it would have a significant impact on this PR if we decided to instead surface a more generic "ad server ad slot" field. |
|
Closing in favor of more recent discussion on prebid/Prebid.js#7367 getting documented i a different PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documents prebid/Prebid.js#6688 and other recent bidder changes