Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial document for groupm as pubmatic alias #3399

Merged
merged 2 commits into from
Feb 3, 2022

Conversation

pm-isha-bharti
Copy link
Contributor

No description provided.

@ChrisHuie ChrisHuie changed the title Initial document for groupm Initial document for groupm as pubmatic alias Nov 10, 2021
@ChrisHuie ChrisHuie self-assigned this Nov 10, 2021
| `adSlot` | optional | Ad Slot Name (see below)| `'38519891'` | `string` |
| `pmzoneid` | optional | Zone ID | `'zone1,zone2'` | `string` |
| `lat` | optional | Latitude | `'40.712775'` | `string` |
| `lon` | optional | Longitude | `'-74.005973'` | `string` |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pm-isha-bharti I see that the bidder params listed here don't exactly match what you have in Prebid Server. These docs are meant to communicate to the Publisher enabling Groupm as a bidder what parameters they need to pass to Prebid Server in the request for the Groupm bidder and so they should match what you have specified in the static/bidder-params/groupm.json file in the Prebid Server PR

Copy link
Contributor Author

@pm-isha-bharti pm-isha-bharti Nov 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mansinahar The params that I have mentioned are supported at the prebid JS end and since groupM is an alias of pubmatic, I have kept the params similar to pubmatic.md
Should I add a separate section( "Prebid Server Test Request" ) for prebid-server request in the same document as I can see this section in other bidders docs as well?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pm-isha-bharti Ah ok! But I still see wrapper and keywords in the prebid server params file for Groupm but not in this doc. Can you please include those as well? And yeah, I think adding a test Prebid Server request is a good idea. Thanks!

@MartianTribe MartianTribe merged commit cb903d8 into prebid:master Feb 3, 2022
jlaso pushed a commit to AuDigent/prebid.github.io that referenced this pull request Nov 6, 2024
* Initial document for groupm

* Added PBS params and test request for groupm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants