-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial document for groupm as pubmatic alias #3399
Conversation
| `adSlot` | optional | Ad Slot Name (see below)| `'38519891'` | `string` | | ||
| `pmzoneid` | optional | Zone ID | `'zone1,zone2'` | `string` | | ||
| `lat` | optional | Latitude | `'40.712775'` | `string` | | ||
| `lon` | optional | Longitude | `'-74.005973'` | `string` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pm-isha-bharti I see that the bidder params listed here don't exactly match what you have in Prebid Server. These docs are meant to communicate to the Publisher enabling Groupm
as a bidder what parameters they need to pass to Prebid Server in the request for the Groupm
bidder and so they should match what you have specified in the static/bidder-params/groupm.json
file in the Prebid Server PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mansinahar The params that I have mentioned are supported at the prebid JS end and since groupM
is an alias of pubmatic
, I have kept the params similar to pubmatic.md
Should I add a separate section( "Prebid Server Test Request
" ) for prebid-server request in the same document as I can see this section in other bidders docs as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pm-isha-bharti Ah ok! But I still see wrapper
and keywords
in the prebid server params file for Groupm but not in this doc. Can you please include those as well? And yeah, I think adding a test Prebid Server request is a good idea. Thanks!
* Initial document for groupm * Added PBS params and test request for groupm
No description provided.