Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audigent Halo -> Hadron Rebranding #3509

Merged
merged 5 commits into from
Jan 27, 2022
Merged

Audigent Halo -> Hadron Rebranding #3509

merged 5 commits into from
Jan 27, 2022

Conversation

antlauzon
Copy link
Contributor

This PR provides rebranded documentaiton for Audigent's Hadron modules within Prebid

@antlauzon
Copy link
Contributor Author

@bretg pending prebid/Prebid.js#7938

Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine @anthonylauzon - did you consider adding a transition note like "formerly known as Halo"?

@antlauzon
Copy link
Contributor Author

we are dropping the former branding completely, so will be removing all references to it

Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anthonylauzon - now that the haloRtdProvider will be left until 7.0, I'm thinking that we want to change the docs. How about creating a small file that just points from Halo to Hadron with a note like "We rebranded! Prebid.js will support using the 'Halo' name until 7.0 later this year, but in the meantime, check out the docs under the new name 'Hadron'."

@antlauzon antlauzon requested a review from bretg January 25, 2022 00:21
Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more consideration for haloRtdProvider.md and I think we're good -- update the "enable_download" to false so no new pubs get it?

@antlauzon
Copy link
Contributor Author

changed, prebid/Prebid.js#7938 has been merged

@antlauzon antlauzon requested a review from bretg January 27, 2022 04:34
@bretg
Copy link
Contributor

bretg commented Jan 27, 2022

Cool. Normally we don't merge docs PRs until the code is released. The code PR missed the 6.9 release and is one of the first merged into next week's 6.10

But in this case, if you want to have the docs merged now, I'd do that for you. A bit of possible confusion would be that the site will refer to Hadron and it won't be downloadable.

@ChrisHuie ChrisHuie merged commit 9c82e0b into prebid:master Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants