-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audigent Halo -> Hadron Rebranding #3509
Conversation
@bretg pending prebid/Prebid.js#7938 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine @anthonylauzon - did you consider adding a transition note like "formerly known as Halo"?
we are dropping the former branding completely, so will be removing all references to it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anthonylauzon - now that the haloRtdProvider will be left until 7.0, I'm thinking that we want to change the docs. How about creating a small file that just points from Halo to Hadron with a note like "We rebranded! Prebid.js will support using the 'Halo' name until 7.0 later this year, but in the meantime, check out the docs under the new name 'Hadron'."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more consideration for haloRtdProvider.md and I think we're good -- update the "enable_download" to false so no new pubs get it?
changed, prebid/Prebid.js#7938 has been merged |
Cool. Normally we don't merge docs PRs until the code is released. The code PR missed the 6.9 release and is one of the first merged into next week's 6.10 But in this case, if you want to have the docs merged now, I'd do that for you. A bit of possible confusion would be that the site will refer to Hadron and it won't be downloadable. |
This PR provides rebranded documentaiton for Audigent's Hadron modules within Prebid