Tappx :: avoid host #3520
Merged
Tappx :: avoid host #3520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes is in response to the pull request: prebid/prebid-server#2130
bretg
reviewed
Jan 24, 2022
There was a problem hiding this comment.
appreciate the doc update @prebidtappx , but since you support both Prebid Server and Prebid.js, please confirm that the host param is optional for both. I don't see any PRs for PBJS.
Change thanks to Bretg in the pull request: prebid/prebid-server#2130 I take a look to prebid.js module of tappx and we will made the same change in a near future. However, it is better to put correctly in the docs. Thanks.
Hi! True, I made a new commit to be sure that the documentation is exactly like actual situation. |
|
Hi bretg! The pull request was merged, we can merge this doc too? |
MartianTribe
approved these changes
Feb 2, 2022
jlaso
pushed a commit
to AuDigent/prebid.github.io
that referenced
this pull request
Nov 6, 2024
* Tappx :: avoid host This changes is in response to the pull request: prebid/prebid-server#2130 * Change to be more accurate Change thanks to Bretg in the pull request: prebid/prebid-server#2130 I take a look to prebid.js module of tappx and we will made the same change in a near future. However, it is better to put correctly in the docs. Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes is in response to the pull request: prebid/prebid-server#2130