Update Connatix Docs With Video Media Type Support #5480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
10 tasks
muuki88
requested changes
Jul 8, 2024
dev-docs/bidders/connatix.md
Outdated
| @@ -24,30 +24,111 @@ ortb_blocking_supported: true | |||
| sidebarType: 1 | |||
| --- | |||
|
|
|||
| <div style="height: 2px; background-color: #333333; width: 100%" ></div> | |||
There was a problem hiding this comment.
Suggested change
| <div style="height: 2px; background-color: #333333; width: 100%" ></div> |
Those custom HTML is not needed. This makes it less consistent with the rest of the docs and thus less consumable.
There was a problem hiding this comment.
Deleted the div separators.
dev-docs/bidders/connatix.md
Outdated
| {: .table .table-bordered .table-striped } | ||
| | Name | Scope | Description | Example | Type | | ||
| |----------------|--------------------|----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|---------|-----------| | ||
| | sizes| required | All the sizes of the banner this ad unit can accept. | [[300, 250], [300, 600]] | Array\<Array\<integer> > | |
There was a problem hiding this comment.
This is only a question as you seem to be an engineer. Would the typescript syntax be more readable here. So
// before
Array<Array<integer>>
// after
[number, number][]
There was a problem hiding this comment.
It will indeed. I changed the type for that banner param. Thanks for pointing it out!
There was a problem hiding this comment.
Nice to hear 😊 I'll talk to the docs team if we should move to this syntax in the future.
muuki88
approved these changes
Jul 8, 2024
|
released with PBJS 9.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🏷 Type of documentation
📋 Checklist