Adkernel: documenting UrekaMedia alias #5790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
1 task
bretg
requested changes
Jan 6, 2025
There was a problem hiding this comment.
Noticed two things to discuss:
- You cannot claim tcfeu_supported: true without a proper gvl_id.
- It is unreasonable to require the hostname parameter. This pushes too much complexity onto publishers. Instead, host should be an optional parameter that has a default in the adapter code.
|
Apparently adkernel has been requiring the host parameter for Prebid.js for a while. So we can let that one go for now. The GVL ID has to be supplied for UrekaMedia or tcfeu_supported needs to be false. Thanks. |
bretg
approved these changes
Jan 9, 2025
|
this was released as part of 9.26. merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🏷 Type of documentation
📋 Checklist