Add CentOS 7 + Devtoolset 7 image #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To be sure: the binaries are forward compatible as well, right? So they can replace the ones we currently build on Travis Ubuntu. |
vweevers
requested changes
Oct 2, 2019
yep, like magic. The RHEL folks put in a ton of work to make the devtoolsets work on their older base systems (libc mainly), which involves shipping a delta library that contains the new stuff that can be statically linked in where it's used. We use this method for building Node binary releases. Of course it would be worth producing a test prebuild if possible to have complete confidence in it. |
rvagg
added a commit
to Level/leveldown
that referenced
this pull request
Oct 2, 2019
* Remove prebuild settings from standard "linux" job * Add centos7 job with prebuild settings * Add centos7-devtoolset7 docker image prebuild script Ref: prebuild/docker-images#8
rvagg
added a commit
to Level/leveldown
that referenced
this pull request
Oct 2, 2019
* Remove prebuild settings from standard "linux" job * Add centos7 job with prebuild settings * Add centos7-devtoolset7 docker image prebuild script Ref: prebuild/docker-images#8 Ref: #672
vweevers
approved these changes
Oct 2, 2019
ralphtheninja
approved these changes
Oct 3, 2019
|
@rvagg Invited you to prebuild org. Join if you like 😄 |
|
Added to Docker Hub, it's building now. |
|
Build completed. But it seems |
|
After
Symbols: Click to expand |
|
Also works in Debian 8! At least when tested with: As well as on Node.js 13 (using a nightly build from a few days ago, same one I used to test the current |
|
Awesome, that means it'll even run on Ubuntu 14.04 (I'm ashamed to say I still maintain a 14.04 system), RHEL 7, and of course CentOS 7. So, all major still-supported Linux distro versions are supported by these binaries. |
|
Agree, see #1. AFAIK there are no other consumers yet. That can change if we invest some time in documentation (and perhaps additional tooling) for native addon authors. The platform support of leveldown is quite good and its setup can serve as an inspiration, ultimately benefiting end users. |
vweevers
pushed a commit
to Level/leveldown
that referenced
this pull request
Oct 4, 2019
* Remove prebuild settings from standard "linux" job * Add centos7 job with prebuild settings * Add centos7-devtoolset7 docker image prebuild script Ref: prebuild/docker-images#8 Ref: #672
|
Some docs now available here: https://github.com/prebuild/prebuildify-cross#images. I'll move that to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: Level/leveldown#672
The neat thing about this is that you get to compile with gcc 7 but glibc 2.17, so binaries are compatible for Ubuntu 14.04 and Debian 8.