-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mapping-tester repetitions as separate script #226
base: develop
Are you sure you want to change the base?
Conversation
e7d25e5
to
56c6802
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is currently no option to recover details about individual runs, once all repetitions are completed, right? Or do we store the json file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think with this we should also provide a script to process the data statistically across various runs, no?
The script currently doesn't clean up intermediates. Running it for 5 repetitions results in:
The various |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ok. I think then this essentially a python version of what I once implemented in bash. The nice thing about the bash script was actually that it served a central steering component around all the scripts in the mapping tester. However, you can still add the repetition script provided here, as one can still use the bash version as a central instance if deemed necessary
Will add this as a separate PR. Adding backends for both polars and pandas makes this a bit painful. |
9f96fc4
to
56c6802
Compare
Main changes of this PR
Based on #225
Replaces #195
This PR adds a separate python script
repeat.py
to the mapping tester to handle repetitions, which are useful for runtime measurements.It repeats for each repetition:
file-n.csv
Then it merges all N
file-n.csv
into a singlefile.csv
.The column
run
indicates which repetition it was.Author's checklist
pre-commit
hook and usedpre-commit run --all
to apply all available hooks.docs/README.md
../changelog-entries/
(create if necessary).precice/tutorials/aste-turbine
.