Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make bindings compatible with preCICE v3 #47

Merged
merged 4 commits into from
Jan 26, 2024
Merged

Make bindings compatible with preCICE v3 #47

merged 4 commits into from
Jan 26, 2024

Conversation

IshaanDesai
Copy link
Member

@IshaanDesai IshaanDesai commented Jan 25, 2024

The CI tests the solverdummy and also the explicit and implicit variants of the ODE-ODE tutorial. Success of the CI pipeline can be considered as a sufficiently good test of the bindings themselves.

@IshaanDesai IshaanDesai self-assigned this Jan 25, 2024
Copy link
Member

@BenjaminRodenberg BenjaminRodenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not run the code, but CI looks good and only minor changes.

@IshaanDesai IshaanDesai merged commit e45a0c5 into develop Jan 26, 2024
12 checks passed
@IshaanDesai IshaanDesai deleted the precice-v3 branch January 26, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants