Release v2.2.1.1 #105
Release v2.2.1.1 #105
Conversation
* Remove travis * Update build-and-test.yml to use minimal image Co-authored-by: Ishaan Desai <[email protected]> Co-authored-by: Benjamin Rodenberg <[email protected]>
|
@BenjaminRodenberg is the Spack build expected to fail right now? |
There was a problem hiding this comment.
From my side this PR looks good.
The failing spack test is a tricky issue. I assume that this is a problem on precice@develop and not on [email protected]. However, we currently don't know, since we do not test using [email protected]. From my perspective a manual test with [email protected] should be sufficient for this release. On the long run we should think about our testing strategy
- for the python bindings, when the spack environment is updated (weekly cron job)
- for precice, since we currently don't have any information on the status of the spack package precice@develop.
|
The failing Spack build might be simply a Spack artifact when using the Python module in a fresh Spack environment. However, the Spack environment is not touched/changed. It could also be related #86 which means that the Python module is installed to a location where we do not expect/want it to be. Maybe the module is in the environment of a/the wrong Python installation. At least the output suggest that the Python modules was built and installed successfully. |
|
I just restarted the failing test twice and now it passed twice. I am not sure what to conclude here. I would guess this PR is fine for now. |
This release is required due to a bug fix release of preCICE v2.2.1
Features of this release: