Update Spack recipe #116
Merged
Update Spack recipe #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenjaminRodenberg
approved these changes
Aug 11, 2021
There was a problem hiding this comment.
Since this PR mostly reflects spack/spack#25077, I think we should merge it without minor changes. For the future: Let's just synchronize with the upstream spack recipe without any PRs. If there are additional changes that we want to apply on top of the upstream recipi, I would suggest to independently develop this here and merge it into the upstream spack repository with the next release.
Only thing we should do: Add a Changelog entry here, if there a major changes.
IshaanDesai
approved these changes
Aug 11, 2021
BenjaminRodenberg
added a commit
that referenced
this pull request
Aug 13, 2021
This reverts commit c5b19c7.
BenjaminRodenberg
added a commit
that referenced
this pull request
Aug 13, 2021
This reverts commit c5b19c7.
|
I'm reverting the contribution of this PR in #121. Will reopen a new PR with the contents of this PR in a moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Spack recipe included in the repository:
The Spack recipe included in the repository is updated to the current version which is included in the official Spack repository. There have been significant changes and simplifications in a recent PR spack/spack#25077.
I think it makes sense to keep the Spack recipe in our repository up to date.
Replaces #115