Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run CI also on PRs #118

Merged
merged 4 commits into from
Aug 12, 2021
Merged

Run CI also on PRs #118

merged 4 commits into from
Aug 12, 2021

Conversation

BenjaminRodenberg
Copy link
Member

@BenjaminRodenberg BenjaminRodenberg commented Aug 11, 2021 •
edited
Loading

Resulting from #117, since tests are currently not triggered by PRs from forks.

@BenjaminRodenberg BenjaminRodenberg added the enhancement New feature or request label Aug 11, 2021
@BenjaminRodenberg BenjaminRodenberg self-assigned this Aug 11, 2021
@BenjaminRodenberg
Copy link
Member Author

The following tests are excluded from PRs:

  • build-docker.yml not useful for PRs, since the generated dockerfile is only used by the preCICE systemtests. Would still be useful to know whether a PR breaks the generation of the dockerfile, but this would also come with additional requirements to the contributor (has to configure own a dockerhub account and configure the fork correspondingly). Therefore, I would rather drop this test for PRs.
  • build-env.yml similar to build-docker.yml. Additionally, we currently do not have a proper system for uniquely identifying containers generated from branches. See also Update Spack CI  #117 (comment).
  • pythonpublish.yml only relevant for releases.

ajaust
ajaust approved these changes Aug 11, 2021
View reviewed changes
Copy link
Collaborator

@ajaust ajaust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me so far.

@BenjaminRodenberg BenjaminRodenberg merged commit 00fa2c0 into develop Aug 12, 2021
@BenjaminRodenberg BenjaminRodenberg deleted the BenjaminRodenberg-run-ci-on-pr branch August 13, 2021 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajaust ajaust ajaust approved these changes

Assignees

@BenjaminRodenberg BenjaminRodenberg

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BenjaminRodenberg @ajaust