Adding direct mesh access experimental functions #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All tests fail because the docker image |
BenjaminRodenberg
requested changes
Oct 7, 2021
There was a problem hiding this comment.
I added some more comments below. Some smaller issues on documentation. Testing is probably a slightly bigger work package.
There are also some more comments that probably should go to the C++ side of the interface. But I think you can judge better here. I'm missing a lot of context about the C++ interface, so they might not 100% fit.
…roper dimensions are provided
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding two new API functions related to functionality for direct access to received meshes. More details: precice/precice#1033
closes #123