Support preCICE Waveform API #146
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Everything except the spack tests are working here. (I currently do not have the time to look deeper into spack) I will now also create a breaking PR for the 3.0.0 release of preCICE. |
|
Can we sync this with the latest develop to ensure that when we plan to merge this we would not have excessive conflicts? |
Done. |
IshaanDesai
reviewed
Oct 13, 2022
IshaanDesai
reviewed
Oct 13, 2022
IshaanDesai
reviewed
Oct 13, 2022
IshaanDesai
reviewed
Oct 13, 2022
IshaanDesai
approved these changes
Oct 13, 2022
Co-authored-by: Ishaan Desai <[email protected]>
BenjaminRodenberg
added
the
breaking change
|
@IshaanDesai Thanks for the review and the suggestion! I would suggest to merge this PR as soon as precice/precice#1366 is merged, because this PR is also a breaking one and relies on |
Co-authored-by: Ishaan Desai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not necessarily breaking, because the waveform API was already introduced in preCICE v2.4.0.