Adapted compatibility-precice-dev branch #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 11, 2023 19:43
…; deleted misbehaving imports in __init__.py
Timo-Schrader
changed the title
BenjaminRodenberg
approved these changes
Jan 11, 2023
There was a problem hiding this comment.
All looks good to me 👍 I did not check it thoroughly, but let's merge this one quick and then we continue working in #159 together. Thank you!
IshaanDesai
added a commit
that referenced
this pull request
Feb 20, 2023
* [WIP] Make bindings compatible with precice:develop * Updating solverdummy and checkpoint related API functions * Removing unnecessary semicolons * Add correct arguments to functions in SolverInterface.cpp * Add size as input argument to mesh connectivity API functions for testing * Remove incorrect bracket from deleted namespace * [WIP] Using same names for input arguments of API functions * correct return type for setMeshEdge in SolverInterface.cpp * void function setMeshEdge should not return anything * Adapted compatibility-precice-dev branch (#162) * Use precice-setup-action * Modify solverdummy Action * Use precice-setup action appropriately in steps * Change apt-get commands to use sudo in build and test workflows * Change rm -rf commands to use sudo in build and test workflows * Remove get_mesh_vertices and get_mesh_vertex_ids_from_positions * Use precice-setup-action in Spack workflow * Simplify testing. * Remove sudo. * Use benjaminrodenberg/precice:develop * Try with root user. * Update solverdummies test. * Fix solverdummy. --------- Co-authored-by: Ishaan Desai <[email protected]> Co-authored-by: Timo-Schrader <[email protected]>
IshaanDesai
added a commit
that referenced
this pull request
Mar 9, 2023
* [WIP] Make bindings compatible with precice:develop * Updating solverdummy and checkpoint related API functions * Removing unnecessary semicolons * Add correct arguments to functions in SolverInterface.cpp * Add size as input argument to mesh connectivity API functions for testing * Remove incorrect bracket from deleted namespace * [WIP] Using same names for input arguments of API functions * correct return type for setMeshEdge in SolverInterface.cpp * void function setMeshEdge should not return anything * Adapted compatibility-precice-dev branch (#162) * Use precice-setup-action * Modify solverdummy Action * Use precice-setup action appropriately in steps * Change apt-get commands to use sudo in build and test workflows * Change rm -rf commands to use sudo in build and test workflows * Remove get_mesh_vertices and get_mesh_vertex_ids_from_positions * Use precice-setup-action in Spack workflow * Use main branch of setup-precice-action * Use container precice/precice:develop * Remove sudo from build-and-test.yml * Use C++17 in setup.py * Install sudo in workflows and use it to remove lock file * Use user: root in setup_test workflow * Remove sudo from the command to remove lock files --------- Co-authored-by: Timo-Schrader <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
returnstatement in l. 593 ofcyprecice/cyprecice.pxy(please confirm that this is correct)importstatements in__init__.pysince these functions do no longer exist.