Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👀 comment out reset layout #228

Merged
merged 1 commit into from
Jul 9, 2023
Merged

👀 comment out reset layout #228

merged 1 commit into from
Jul 9, 2023

Conversation

jvdd
Copy link
Member

@jvdd jvdd commented Jun 18, 2023

Fixes #223

@codecov-commenter
Copy link

codecov-commenter commented Jun 18, 2023

Codecov Report

Merging #228 (78461a5) into main (c905478) will increase coverage by 0.04%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #228      +/-   ##
==========================================
+ Coverage   97.06%   97.11%   +0.04%     
==========================================
  Files          13       13              
  Lines         988     1005      +17     
==========================================
+ Hits          959      976      +17     
  Misses         29       29              
Impacted Files Coverage Δ
...ler/figure_resampler/figure_resampler_interface.py 99.74% <ø> (+<0.01%) ⬆️

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jvdd
Copy link
Member Author

jvdd commented Jun 18, 2023

@jonasvdd any reason why we had the reset layout (autorange & range) for x and y axes in the constructor?


If we have a legit reason to do this, we can toggle this behavior by adding a new constructor argument (e.g., reset_axes_range, which defaults to True)

@jonasvdd
Copy link
Member

jonasvdd commented Jul 3, 2023

I'm fine with commenting this out!

@jvdd jvdd marked this pull request as ready for review July 9, 2023 08:48
@jvdd jvdd merged commit 2125b66 into main Jul 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't automatically add axis: {"autorange": True, "range": None} when converting existing figures
3 participants