-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add source built serial monitor rust #5
Add source built serial monitor rust #5
Conversation
💵 To receive payouts, sign up on Algora, link your Github account and connect with Stripe. |
@wolfv I am a bit new to this process and focused on preparing the conda-forge recipe under: |
Wow! I'll fix up the stdlib thing in this repo tomorrow! |
Cool, is it that there are no defaults? Should I no rather update with a |
I'm a bit confused to what you want to build - the way I see it, this does not create any bundles for the serial monitor, just the binary, right? and how did you select the third-party crates that you implemented a recipe for? are they required at all and why did you not implement all of them (for example |
The primary reason to add the extra builds was that they are pulled-in as Keep in mind also that I am not an expert in conda-forge packages, this is just the way I understand it. The problem I see with binary distribution is that it is possible that they break for a particular conda-forge environment. When packages are built from source they should more likely to conform to any conda-forge environments. |
The issue with |
@hacknus In fact, do you mind updating your @wolfv My understanding was that you wanted the recipe on So many questions ... and it's at that moment that they truly understood why the nickname is |
I see, makes sense. I can look into it. But I still do not understand why you do not bundle the serial monitor, you only build the binary. If the versions would be fixed and no dependencies would get pulled from git, then #4 would be sufficient? |
From my experience, I do not think that conda-forge would be favorable to bundled binaries, but @wolfv should be addressing that part when he reviews the 2 submissions. I have only ever built source-based conda packages, so that's what I proposed here. A more concerning issue that is likely related to the bundling is: "How do you bundle for OSX". The issues that I am encountering here is that conda uses SDKROOT to point to the minimal SDK version to deploy for, but I am currently looking into repackaging a patched |
I see, yes. Serial Monitor was built to run as a bundled application, since it is a GUI. But of course you could also launch it from the command line..
Interesting, I have not had a problem with that using |
v0.3.1 is now only depending on releases of dependencies. |
The end-user will likely use it as a GUI, within its conda environment, which would install the appropriate libs and resolve potential conflicts, i think that's a key feature for conda and the way the packages are built must be controlled (at least that's my understanding)
Right, I have a bit of a hard time getting the gist of it, cargo and conda may be overlapping in what they're trying to achieve, I had similar misunderstandings when working on clojure with its maven framework |
@hacknus Thank you, the recipe is cleaner now. I am still working on that OSX SDK issue on the conda-staged recipe (i'd rather have tons of commits on that one than here!). It would be great if you were interested in helping maintaining this recipe, I would focus on the conda maintenance and you'd be the expert on the real meat of the package, as well as Rust, of which I know very little (Assuming, of course, that @wolfv selects it! ;p) |
I'll continue to maintain |
Please update |
Finally ... conda-forge still not working though, oddly |
FYI, the whole thing with pulling the git-repos of the dependencies is not necessary anyways, since the specific commits are locked in the |
/claim #2