fix: improve version conversion #1201
Conversation
|
Thanks @wolfv ! I am not sure of what order of precedence we should have (if any). When I thought about it, it seemed more logical to me to let the solver handle various constraints, coming from various tables |
|
@olivier-lacroix that works, theoretically! Unfortunately calling |
src/project/manifest/pyproject.rs
Outdated
| version_or_url_to_nameless_matchspec(&pythonspec).unwrap(), | ||
| SpecType::Run, | ||
| ); | ||
| if !target.has_dependency("python", Some(SpecType::Run)) || python_spec.is_some() { |
There was a problem hiding this comment.
We should not make the requires-python be more important then the pixi one. This won't let the user overwrite it if they want a different version from what the build package is allowed to use. e.g.
requires-python = `>=3.7` Will always give you the latest version but users might want to run their environment on 3.9 and then they can't overwrite that in the tool.pixi section.
There was a problem hiding this comment.
So we also don't want a warning, in that case?
There was a problem hiding this comment.
I don't think so, it will get annoying fast. Possibly an tracing::info
There was a problem hiding this comment.
Do we want to not do anything for other interpreters? Pypy, etc…
Ah. Then indeed, I think it would make sense to have the pixi.dependency table take precedence over the require-python |
ruben-arts
changed the title
|
Great! Thanks @wolfv ! |
|
Just to note - this overrides the It would be a future improvement to take both constraints into account. |
Just, to make sure: The fact that I have this in the # cat pyproject.toml | grep "requires-python"
requires-python = "~= 3.11"But my "default" # pixi run python -V
Python 3.12.3...is an expected behavior? Do I need to add the same constraint to |
|
You should not need to. But the conversion between pypi & conda constraints is pretty simple at the moment. Basically, your |
This improves the logic a little bit.
Python versions like
==3.11.*now get parsed to3.11.*which works better for conda requirements.We warn the user if there is both a
requires-pythonand apythondependency in thetool.pixi.dependenciessection.We prefer the
requires-pythonover a value in the pixi deps.cc @olivier-lacroix
fixes #1193