Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add check error message to remove uv dependencies #3052

Merged
merged 6 commits into from
Feb 5, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions src/cli/remove.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
use clap::Parser;
use miette::Context;
use pixi_manifest::FeaturesExt;

use crate::environment::get_update_lock_file_and_prefix;
use crate::Project;
Expand Down Expand Up @@ -40,8 +41,29 @@ pub async fn execute(args: Args) -> miette::Result<()> {
.with_cli_config(prefix_update_config.config.clone());
let dependency_type = dependency_config.dependency_type();

// Prevent removing Python if PyPI dependencies exist
if let DependencyType::CondaDependency(_) = dependency_type {
for name in dependency_config.specs()?.keys() {
if name.as_source() == "python" {
// Check if there are any PyPI dependencies by importing the PypiDependencies trait
let pypi_deps = project.default_environment().pypi_dependencies(None);
if !pypi_deps.is_empty() {
let deps_list = pypi_deps
.iter()
.map(|(name, _)| name.as_source())
.collect::<Vec<_>>()
.join(", ");
return Err(miette::miette!(
"Cannot remove Python while PyPI dependencies exist. Please remove these PyPI dependencies first: {}",
deps_list
));
}
}
}
}
match dependency_type {
DependencyType::PypiDependency => {
let mut removed_deps = Vec::new();
Dozie2001 marked this conversation as resolved.
Show resolved Hide resolved
for name in dependency_config.pypi_deps(&project)?.keys() {
project
.manifest
Expand All @@ -54,7 +76,13 @@ pub async fn execute(args: Args) -> miette::Result<()> {
"failed to remove PyPI dependency: '{}'",
name.as_source()
))?;
removed_deps.push(name.as_source().to_string());
}
eprintln!(
"{}Removed PyPI dependencies: {}",
console::style(console::Emoji("✔ ", "")).green(),
removed_deps.join(", ")
);
Dozie2001 marked this conversation as resolved.
Show resolved Hide resolved
}
DependencyType::CondaDependency(spec_type) => {
for name in dependency_config.specs()?.keys() {
Expand Down
Loading