Avoid fetching all tags on git clone/fetch #1089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Looks like a few tests don't work with this change yet :/ |
|
Ah interesting, it passes locally for me. I wonder if this is related to git version -- looking... |
|
Ah nevermind, just wasn't using the correct command line to include this test :P |
|
THe issue was that the test recipe was specifying a "tag" using |
By default, git fetch/clone will download all tags from the remote repo, so pass `--no-tags` to avoid some unnecessary downloading.
|
Ouch! Thanks for fixing all this! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, git fetch/clone will download all tags from the remote repo, so pass
--no-tagsto avoid some unnecessary downloading -- we'll still explicitly fetch any tag we need to checkout.