Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for --locked and --frozen #21

Merged
merged 9 commits into from
Oct 3, 2023
Merged

Add support for --locked and --frozen #21

merged 9 commits into from
Oct 3, 2023

Conversation

pavelzw
Copy link
Collaborator

@pavelzw pavelzw commented Oct 3, 2023

setup-pixi uses --locked by default now. This breaks setup-pixi for pixi<0.5.0. To still use pixi<0.5.0, you need to specify locked: false.

@ruben-arts
Copy link
Contributor

You're quick! Wouldn't you want it to fail if the lock file is outdated as default?

@pavelzw
Copy link
Collaborator Author

pavelzw commented Oct 3, 2023

I personally would prefer a working CI even though the lockfiles are not up-to-date (i mean everything is working after all, it's just not at up to date 😅). If we use --locked by default, this would probably result in a lot of red CI over time that would need to be investigated for no reason.

IMO dependabot or renovate should update the lockfile instead every week or so 🤷🏻

@ruben-arts
Copy link
Contributor

Ah I think you have a different idea of an out of date lockfile.

If you specify python >= 3.11 in your pixi.toml and your lockfile holds python = 3.11.0. Then this lockfile is up to date, and can stay --locked. Even if there would be a 3.11.1 available.

Only when you specify a >= 3.12 in your pixi.toml with a python = 3.11.0 in your pixi.lock the --locked will fail. So this should only give you "red CI" if you updated your pixi.toml without also updating the pixi.lock.

@pavelzw
Copy link
Collaborator Author

pavelzw commented Oct 3, 2023

Ah, I see! Maybe we should write down this notion in the pixi docs 😅

@pavelzw pavelzw added enhancement New feature or request breaking labels Oct 3, 2023
@pavelzw pavelzw requested a review from ruben-arts October 3, 2023 09:54
@pavelzw pavelzw marked this pull request as ready for review October 3, 2023 09:57
Copy link
Contributor

@ruben-arts ruben-arts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

.github/workflows/test.yml Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
@pavelzw pavelzw enabled auto-merge (squash) October 3, 2023 11:48
@pavelzw pavelzw merged commit e2bb9e2 into main Oct 3, 2023
@pavelzw pavelzw deleted the frozen branch October 3, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants