Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix form action message #436

Merged
merged 5 commits into from
Sep 27, 2024
Merged

Fix form action message #436

merged 5 commits into from
Sep 27, 2024

Conversation

cregourd
Copy link
Collaborator

@cregourd cregourd commented Sep 26, 2024

Title

Fix form action message

Type of Change

  • New feature
  • Bug fix
  • Documentation update
  • Example update
  • Refactoring
  • Hotfix
  • Security patch
  • UI/UX improvement

Issue

#434
#435

Description

When taking action, messages do not appear on form

  • Allow custom actions messages
  • Allow custom dialog actions messages
  • type prop is now required on actions items
  • action function now can return a Message object to display a message after the action is done
  • Error thrown by action function are now caught and displayed in a message
  • onClose prop can now receive a Message object to display a message after the dialog is closed

Screenshots

image

Impact

  • type property in actions option is mandatory

Copy link

changeset-bot bot commented Sep 26, 2024

🦋 Changeset detected

Latest commit: 864b08d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@premieroctet/next-admin Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@cregourd cregourd marked this pull request as ready for review September 26, 2024 13:15
@cregourd cregourd requested a review from foyarash September 26, 2024 14:16
@cregourd cregourd merged commit 68700e6 into main Sep 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants