Add i18n support #90
Merged
Add i18n support #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1b5dd6d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
tlenclos
reviewed
Dec 13, 2023
| @@ -0,0 +1,20 @@ | |||
| { | |||
There was a problem hiding this comment.
It's easier to maintain flat translation file like
admin.actions.user.email.title
There was a problem hiding this comment.
This nested notation is the only one supported by next-intl
tlenclos
reviewed
Dec 13, 2023
Comment on lines
+19
to
+29
| const t = (key: string, options?: { [key: string]: any }) => { | ||
| let translation = translations[key]; | ||
|
|
||
| if (options && translation) { | ||
| Object.entries(options).forEach(([key, value]) => { | ||
| translation = translation!.replace(`{{${key}}}`, value); | ||
| }); | ||
| } | ||
|
|
||
| return translation ?? key; | ||
| }; |
There was a problem hiding this comment.
Can you add a test for this function ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#68