Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSON editor in NextAdmin core #92

Merged
merged 11 commits into from
Feb 12, 2024
Merged

Conversation

cregourd
Copy link
Collaborator

@cregourd cregourd commented Jan 4, 2024

Added JSON editor to the heart of Next-Admin. However, the optional @monaco-editor/react dependency must be installed in the application, to prevent next-admin from embedding unused libraries if this editor is not installed.

image

Copy link

changeset-bot bot commented Jan 4, 2024

🦋 Changeset detected

Latest commit: a4de91a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@premieroctet/next-admin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@cregourd cregourd requested a review from tlenclos January 4, 2024 10:24
@cregourd cregourd marked this pull request as draft January 4, 2024 10:31
@cregourd cregourd marked this pull request as ready for review January 4, 2024 14:40
# Conflicts:
#	packages/next-admin/src/components/Form.tsx
#	packages/next-admin/src/types.ts
# Conflicts:
#	apps/example/package.json
#	packages/next-admin/package.json
#	packages/next-admin/src/components/Form.tsx
#	packages/next-admin/src/components/inputs/JsonField.tsx
#	packages/next-admin/src/types.ts
@cregourd cregourd merged commit 29ec67f into main Feb 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants