forked from apache/superset
-
Notifications
You must be signed in to change notification settings - Fork 11
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore: Add tests to SQL lab button components (apache#22916)
- Loading branch information
1 parent
baec9dd
commit 4873c09
Showing
6 changed files
with
194 additions
and
70 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
95 changes: 95 additions & 0 deletions
95
...frontend/src/SqlLab/components/ExploreCtasResultsButton/ExploreCtasResultsButton.test.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,95 @@ | ||
/** | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
import React from 'react'; | ||
import configureStore from 'redux-mock-store'; | ||
import fetchMock from 'fetch-mock'; | ||
import thunk from 'redux-thunk'; | ||
import { fireEvent, render, waitFor } from 'spec/helpers/testing-library'; | ||
import { Store } from 'redux'; | ||
import { SupersetClientClass } from '@superset-ui/core'; | ||
import { initialState } from 'src/SqlLab/fixtures'; | ||
|
||
import ExploreCtasResultsButton, { | ||
ExploreCtasResultsButtonProps, | ||
} from 'src/SqlLab/components/ExploreCtasResultsButton'; | ||
|
||
const middlewares = [thunk]; | ||
const mockStore = configureStore(middlewares); | ||
|
||
const getOrCreateTableEndpoint = `glob:*/superset/get_or_create_table/`; | ||
|
||
const setup = (props: Partial<ExploreCtasResultsButtonProps>, store?: Store) => | ||
render( | ||
<ExploreCtasResultsButton | ||
table="test" | ||
schema="test_schema" | ||
dbId={12346} | ||
{...props} | ||
/>, | ||
{ | ||
useRedux: true, | ||
...(store && { store }), | ||
}, | ||
); | ||
|
||
describe('ExploreCtasResultsButton', () => { | ||
const postFormSpy = jest.spyOn(SupersetClientClass.prototype, 'postForm'); | ||
postFormSpy.mockImplementation(jest.fn()); | ||
|
||
it('renders', async () => { | ||
const { queryByText } = setup({}, mockStore(initialState)); | ||
|
||
expect(queryByText('Explore')).toBeTruthy(); | ||
}); | ||
|
||
it('visualize results', async () => { | ||
const { getByText } = setup({}, mockStore(initialState)); | ||
|
||
postFormSpy.mockClear(); | ||
fetchMock.reset(); | ||
fetchMock.post(getOrCreateTableEndpoint, { table_id: 1234 }); | ||
|
||
fireEvent.click(getByText('Explore')); | ||
|
||
await waitFor(() => { | ||
expect(postFormSpy).toHaveBeenCalledTimes(1); | ||
expect(postFormSpy).toHaveBeenCalledWith('http://localhost/explore/', { | ||
form_data: | ||
'{"datasource":"1234__table","metrics":["count"],"groupby":[],"viz_type":"table","since":"100 years ago","all_columns":[],"row_limit":1000}', | ||
}); | ||
}); | ||
}); | ||
|
||
it('visualize results fails', async () => { | ||
const { getByText } = setup({}, mockStore(initialState)); | ||
|
||
postFormSpy.mockClear(); | ||
fetchMock.reset(); | ||
fetchMock.post(getOrCreateTableEndpoint, { | ||
status: 500, | ||
body: { message: 'Unexpected all to v1 API' }, | ||
}); | ||
|
||
fireEvent.click(getByText('Explore')); | ||
|
||
await waitFor(() => { | ||
expect(postFormSpy).toHaveBeenCalledTimes(0); | ||
}); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
67 changes: 0 additions & 67 deletions
67
superset-frontend/src/SqlLab/components/ExploreResultsButton/ExploreResultsButton.test.jsx
This file was deleted.
Oops, something went wrong.
51 changes: 51 additions & 0 deletions
51
superset-frontend/src/SqlLab/components/ExploreResultsButton/ExploreResultsButton.test.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
/** | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
import React from 'react'; | ||
import { render, screen } from 'spec/helpers/testing-library'; | ||
|
||
import ExploreResultsButton, { | ||
ExploreResultsButtonProps, | ||
} from 'src/SqlLab/components/ExploreResultsButton'; | ||
import { OnClickHandler } from 'src/components/Button'; | ||
|
||
const setup = ( | ||
onClickFn: OnClickHandler, | ||
props: Partial<ExploreResultsButtonProps> = {}, | ||
) => | ||
render(<ExploreResultsButton onClick={onClickFn} {...props} />, { | ||
useRedux: true, | ||
}); | ||
|
||
describe('ExploreResultsButton', () => { | ||
it('renders', async () => { | ||
const { queryByText } = setup(jest.fn(), { | ||
database: { allows_subquery: true }, | ||
}); | ||
|
||
expect(queryByText('Create Chart')).toBeTruthy(); | ||
expect(screen.getByRole('button', { name: 'Create Chart' })).toBeEnabled(); | ||
}); | ||
|
||
it('renders disabled if subquery not allowed', async () => { | ||
const { queryByText } = setup(jest.fn()); | ||
|
||
expect(queryByText('Create Chart')).toBeTruthy(); | ||
expect(screen.getByRole('button', { name: 'Create Chart' })).toBeDisabled(); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters