Skip to content

Commit

Permalink
fix: Pin Prophet dependency after breaking changes (apache#13852)
Browse files Browse the repository at this point in the history
Prophet is heavily dependent on Pystan:
https://facebook.github.io/prophet/docs/installation.html

Pystan has recently (2021-03-25) release its v3.0.0.

This release is not backward compatible and breaks fbprophet:
facebook/prophet#1856

(Indeed, fbprophet 0.6 specifies `pystan>=2.14` — but doesn't restrict
upgrading to next major release:
https://github.com/facebook/prophet/blob/0.6/python/requirements.txt#L3)

So we need to pin pystan to the lastest non 3.x release, while fbprophet
fixes the dependency on their side.

We have taken this opportunity to bump fbprophet too to its next minor
version.

Signed-off-by: Étienne Boisseau-Sierra <[email protected]>
  • Loading branch information
EBoisseauSierra authored and lyndsiWilliams committed Apr 7, 2021
1 parent 0cfc411 commit 836366b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ def get_git_sha():
"postgres": ["psycopg2-binary==2.8.5"],
"presto": ["pyhive[presto]>=0.4.0"],
"trino": ["sqlalchemy-trino>=0.2"],
"prophet": ["fbprophet>=0.6, <0.7"],
"prophet": ["fbprophet>=0.7.1, <0.8", "pystan<3.0"],
"redshift": ["sqlalchemy-redshift>=0.8.1, < 0.9"],
"snowflake": ["snowflake-sqlalchemy>=1.2.3, <1.3"],
"teradata": ["sqlalchemy-teradata==0.9.0.dev0"],
Expand Down

0 comments on commit 836366b

Please sign in to comment.