Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Check docker-build and add required_signatures #85

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .asf.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ github:
# contexts are the names of checks that must pass
contexts:
- check
- docker-release
- docker-build
- frontend-build
- python-lint (3.7)
- test-mysql (3.7)
Expand All @@ -72,3 +72,5 @@ github:
dismiss_stale_reviews: false
require_code_owner_reviews: true
required_approving_review_count: 1

required_signatures: true
3 changes: 1 addition & 2 deletions .github/workflows/docker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,8 @@ on:
types: [synchronize, opened, reopened, ready_for_review]

jobs:
build:
docker-build:
if: github.event.pull_request.draft == false
name: build
runs-on: ubuntu-latest
steps:
- name: "Checkout ${{ github.ref }} ( ${{ github.sha }} )"
Expand Down