Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List necessary cookies #20

Closed
over-engineer opened this issue Jul 26, 2023 · 1 comment
Closed

List necessary cookies #20

over-engineer opened this issue Jul 26, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@over-engineer
Copy link
Member

Expanding on #13, we should add the ability to list Necessary cookies as well, under the “Cookies” tab.

As mentioned in #13, even though deleting necessary cookies is not a thing (since those cookies are essential for the proper functioning of the website and they do not require the explicit consent of a user), we still have to be able to list them to inform users about them.


A few key points to keep in mind:

This change may conflict with existing settings stored in the database for users who have installed versions older than 1.1.2 (the version that’s going to address this issue)

We’ll need to introduce a “migration” process when there are already settings stored in the database.

The migration should run both when:

  • Retrieving settings from the database with a version preceding 1.1.2 (plugin has been updated but we haven’t saved any settings with the new version)

  • Updating settings to ensure a seamless import of exported settings from older versions of the plugin

(cc: @mohammad425)

@over-engineer over-engineer added the enhancement New feature or request label Jul 26, 2023
@over-engineer over-engineer self-assigned this Jul 26, 2023
@over-engineer over-engineer added this to the 1.1.2 milestone Jul 26, 2023
@over-engineer
Copy link
Member Author

This was addressed in 1.1.2, which was just released. Closing as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant