Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for generating the default service descriptor for CoordinatorPlugins #19

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Add support for generating the default service descriptor for CoordinatorPlugins #19

merged 1 commit into from
Sep 23, 2024

Conversation

pdabre12
Copy link
Contributor

@pdabre12 pdabre12 commented Sep 20, 2024 •
edited
Loading

Resolves: #20
Testing: Unit tests

@pdabre12 pdabre12 changed the title Add support for CoordinatorPlugin Add support for generating the default service descriptor for CoordinatorPlugins Sep 20, 2024
@pdabre12 pdabre12 marked this pull request as ready for review September 20, 2024 21:13
@pdabre12
Copy link
Contributor Author

Passing unit tests:

[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running com.facebook.presto.maven.CheckerIntegrationTest
[INFO] Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 16.953 s - in com.facebook.presto.maven.CheckerIntegrationTest
[INFO] Running com.facebook.presto.maven.GeneratorIntegrationTest
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.568 s - in com.facebook.presto.maven.GeneratorIntegrationTest
[INFO] 
[INFO] Results:
[INFO] 
[INFO] Tests run: 12, Failures: 0, Errors: 0, Skipped: 0

@tdcmeehan tdcmeehan merged commit 4102477 into prestodb:master Sep 23, 2024
1 check passed
@pdabre12 pdabre12 deleted the coordinator-plugin branch October 4, 2024 04:58
This was referenced Dec 3, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdcmeehan tdcmeehan tdcmeehan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for generating the default service descriptor for CoordinatorPlugins
2 participants
@pdabre12 @tdcmeehan