Skip to content

Commit

Permalink
Update Low memory Monitor feature config to experimental
Browse files Browse the repository at this point in the history
Enabling low memory monitor has its risk of potential deadlock, so making it experimental.
Also adding details in the config description.
  • Loading branch information
swapsmagic committed Oct 11, 2023
1 parent 6bceeae commit 01c962e
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -588,8 +588,8 @@ public double getMemoryBasedSlowDownThreshold()
return memoryBasedSlowDownThreshold;
}

@Config("task.memory-based-slowdown-threshold")
@ConfigDescription("Pause processing new leaf split if heap memory usage crosses the threshold")
@Config("experimental.task.memory-based-slowdown-threshold")
@ConfigDescription("Pause processing new leaf split if heap memory usage crosses the threshold. This feature is experimental and use it with caution as could lead to deadlock.")
public TaskManagerConfig setMemoryBasedSlowDownThreshold(double memoryBasedSlowDownThreshold)
{
this.memoryBasedSlowDownThreshold = memoryBasedSlowDownThreshold;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ public void testExplicitPropertyMappings()
.put("task.legacy-lifespan-completion-condition", "true")
.put("task.task-priority-tracking", "QUERY_FAIR")
.put("task.interrupt-runaway-splits-timeout", "599s")
.put("task.memory-based-slowdown-threshold", "0.9")
.put("experimental.task.memory-based-slowdown-threshold", "0.9")
.build();

TaskManagerConfig expected = new TaskManagerConfig()
Expand Down

0 comments on commit 01c962e

Please sign in to comment.