Skip to content

Commit

Permalink
[native] Add native-execution-enabled flag to NativeQueryRunnerUtils.…
Browse files Browse the repository at this point in the history
…getNativeWorkerSystemProperties

NativeQueryRunnerUtils.getNativeWorkerSystemProperties is an authoritative set
of native worker system config that are used by several parties when setting up
their clusters.

This property was set in the calling QueryRunner invocations instead leading to
some confusion.
  • Loading branch information
aditi-pandit authored and amitkdutta committed Nov 6, 2023
1 parent f0bd6a5 commit 16970a0
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ public static Map<String, String> getNativeWorkerHiveProperties(String storageFo
public static Map<String, String> getNativeWorkerSystemProperties()
{
return ImmutableMap.<String, String>builder()
.put("native-execution-enabled", "true")
.put("optimizer.optimize-hash-generation", "false")
.put("parse-decimal-literals-as-double", "true")
.put("regex-library", "RE2J")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,6 @@ public static QueryRunner createNativeQueryRunner(
ImmutableMap.<String, String>builder()
.put("http-server.http.port", "8080")
.put("experimental.internal-communication.thrift-transport-enabled", String.valueOf(useThrift))
.put("native-execution-enabled", "true")
.putAll(getNativeWorkerSystemProperties())
.build(),
ImmutableMap.of(),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@ public static Map<String, String> getNativeExecutionSessionConfigs()
// Do not use default Prestissimo config files. Presto-Spark will generate the configs on-the-fly.
.put("catalog.config-dir", "/")
.put("task.info-update-interval", "100ms")
.put("native-execution-enabled", "true")
.put("spark.initial-partition-count", "1")
.put("register-test-functions", "true")
.put("native-execution-program-arguments", "--logtostderr=1 --minloglevel=3")
Expand Down

0 comments on commit 16970a0

Please sign in to comment.