Skip to content

Commit

Permalink
Update Presto on Spark splits assignment test
Browse files Browse the repository at this point in the history
Assertion does not hold after introducing property
`max_spark_input_partition_count_for_auto_tune` for auto tune.
  • Loading branch information
viczhang861 authored and wenleix committed Aug 31, 2020
1 parent fe13c96 commit 21c9c62
Showing 1 changed file with 0 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@
import static com.facebook.presto.spark.PrestoSparkSessionProperties.SPARK_PARTITION_COUNT_AUTO_TUNE_ENABLED;
import static com.facebook.presto.spark.planner.PrestoSparkRddFactory.assignSourceDistributionSplits;
import static com.google.common.collect.Multimaps.asMap;
import static java.lang.String.format;
import static java.util.stream.Collectors.toList;
import static org.testng.Assert.assertEquals;
import static org.testng.Assert.assertTrue;
Expand Down Expand Up @@ -274,7 +273,6 @@ private Map<Integer, List<Long>> assignSplitsToPartition(
long totalPartitionSize = scheduledSplits.stream()
.mapToLong(split -> split.getSplit().getConnectorSplit().getSplitSizeInBytes().getAsLong())
.sum();
assertTrue(totalPartitionSize <= maxPartitionSize, format("Total size for splits in one partition should be less than %d", maxPartitionSize));
}
else {
assertTrue(scheduledSplits.size() == 1, "A partition should hold at least one split");
Expand Down

0 comments on commit 21c9c62

Please sign in to comment.