-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Improve DynamicFiltersChecker to catch unsupported dynamic filters
cherry pick of trinodb/trino@5b74033 Co-Authored-By: James Sun <[email protected]> Co-Authored-By: Raunaq Morarka <[email protected]>
- Loading branch information
3 people
committed
Aug 17, 2020
1 parent
08e260c
commit 8338c0b
Showing
2 changed files
with
200 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
180 changes: 180 additions & 0 deletions
180
...-main/src/test/java/com/facebook/presto/sql/planner/sanity/TestDynamicFiltersChecker.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,180 @@ | ||
| /* | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package com.facebook.presto.sql.planner.sanity; | ||
|
|
||
| import com.facebook.presto.execution.warnings.WarningCollector; | ||
| import com.facebook.presto.expressions.LogicalRowExpressions; | ||
| import com.facebook.presto.metadata.Metadata; | ||
| import com.facebook.presto.spi.ConnectorId; | ||
| import com.facebook.presto.spi.TableHandle; | ||
| import com.facebook.presto.spi.plan.PlanNode; | ||
| import com.facebook.presto.spi.plan.PlanNodeIdAllocator; | ||
| import com.facebook.presto.spi.plan.TableScanNode; | ||
| import com.facebook.presto.spi.relation.VariableReferenceExpression; | ||
| import com.facebook.presto.sql.parser.SqlParser; | ||
| import com.facebook.presto.sql.planner.TypeProvider; | ||
| import com.facebook.presto.sql.planner.assertions.BasePlanTest; | ||
| import com.facebook.presto.sql.planner.iterative.rule.test.PlanBuilder; | ||
| import com.facebook.presto.sql.planner.plan.JoinNode; | ||
| import com.facebook.presto.sql.relational.FunctionResolution; | ||
| import com.facebook.presto.sql.relational.RowExpressionDeterminismEvaluator; | ||
| import com.facebook.presto.testing.TestingTransactionHandle; | ||
| import com.facebook.presto.tpch.TpchColumnHandle; | ||
| import com.facebook.presto.tpch.TpchTableHandle; | ||
| import com.google.common.base.VerifyException; | ||
| import com.google.common.collect.ImmutableList; | ||
| import com.google.common.collect.ImmutableMap; | ||
| import org.testng.annotations.BeforeClass; | ||
| import org.testng.annotations.Test; | ||
|
|
||
| import java.util.Optional; | ||
|
|
||
| import static com.facebook.presto.common.type.BigintType.BIGINT; | ||
| import static com.facebook.presto.sql.planner.optimizations.PredicatePushDown.createDynamicFilterExpression; | ||
| import static com.facebook.presto.sql.planner.plan.JoinNode.Type.INNER; | ||
|
|
||
| public class TestDynamicFiltersChecker | ||
| extends BasePlanTest | ||
| { | ||
| private Metadata metadata; | ||
| private LogicalRowExpressions logicalRowExpressions; | ||
| private PlanBuilder builder; | ||
| private VariableReferenceExpression lineitemOrderKeyVariable; | ||
| private TableScanNode lineitemTableScanNode; | ||
| private VariableReferenceExpression ordersOrderKeyVariable; | ||
| private TableScanNode ordersTableScanNode; | ||
|
|
||
| @BeforeClass | ||
| public void setup() | ||
| { | ||
| metadata = getQueryRunner().getMetadata(); | ||
| logicalRowExpressions = new LogicalRowExpressions( | ||
| new RowExpressionDeterminismEvaluator(metadata.getFunctionManager()), | ||
| new FunctionResolution(metadata.getFunctionManager()), | ||
| metadata.getFunctionManager()); | ||
| builder = new PlanBuilder(getQueryRunner().getDefaultSession(), new PlanNodeIdAllocator(), metadata); | ||
| ConnectorId connectorId = getCurrentConnectorId(); | ||
| TableHandle lineitemTableHandle = new TableHandle( | ||
| connectorId, | ||
| new TpchTableHandle("lineitem", 1.0), | ||
| TestingTransactionHandle.create(), | ||
| Optional.empty()); | ||
| lineitemOrderKeyVariable = builder.variable("LINEITEM_OK", BIGINT); | ||
| lineitemTableScanNode = builder.tableScan(lineitemTableHandle, ImmutableList.of(lineitemOrderKeyVariable), ImmutableMap.of(lineitemOrderKeyVariable, new TpchColumnHandle("orderkey", BIGINT))); | ||
|
|
||
| TableHandle ordersTableHandle = new TableHandle( | ||
| connectorId, | ||
| new TpchTableHandle("orders", 1.0), | ||
| TestingTransactionHandle.create(), | ||
| Optional.empty()); | ||
| ordersOrderKeyVariable = builder.variable("ORDERS_OK", BIGINT); | ||
| ordersTableScanNode = builder.tableScan(ordersTableHandle, ImmutableList.of(ordersOrderKeyVariable), ImmutableMap.of(ordersOrderKeyVariable, new TpchColumnHandle("orderkey", BIGINT))); | ||
| } | ||
|
|
||
| @Test(expectedExceptions = VerifyException.class, expectedExceptionsMessageRegExp = "Dynamic filters present in join were not fully consumed by its probe side.") | ||
| public void testUnconsumedDynamicFilterInJoin() | ||
| { | ||
| PlanNode root = builder.join( | ||
| INNER, | ||
| builder.filter(builder.rowExpression("ORDERS_OK > 0"), ordersTableScanNode), | ||
| lineitemTableScanNode, | ||
| ImmutableList.of(new JoinNode.EquiJoinClause(ordersOrderKeyVariable, lineitemOrderKeyVariable)), | ||
| ImmutableList.of(ordersOrderKeyVariable), | ||
| Optional.empty(), | ||
| Optional.empty(), | ||
| Optional.empty(), | ||
| ImmutableMap.of("DF", lineitemOrderKeyVariable)); | ||
| validatePlan(root); | ||
| } | ||
|
|
||
| @Test(expectedExceptions = VerifyException.class, expectedExceptionsMessageRegExp = "Dynamic filters present in join were consumed by its build side.") | ||
| public void testDynamicFilterConsumedOnBuildSide() | ||
| { | ||
| PlanNode root = builder.join( | ||
| INNER, | ||
| builder.filter( | ||
| createDynamicFilterExpression("DF", ordersOrderKeyVariable, metadata.getFunctionManager()), | ||
| ordersTableScanNode), | ||
| builder.filter( | ||
| createDynamicFilterExpression("DF", ordersOrderKeyVariable, metadata.getFunctionManager()), | ||
| lineitemTableScanNode), | ||
| ImmutableList.of(new JoinNode.EquiJoinClause(ordersOrderKeyVariable, lineitemOrderKeyVariable)), | ||
| ImmutableList.of(ordersOrderKeyVariable), | ||
| Optional.empty(), | ||
| Optional.empty(), | ||
| Optional.empty(), | ||
| ImmutableMap.of("DF", lineitemOrderKeyVariable)); | ||
| validatePlan(root); | ||
| } | ||
|
|
||
| @Test(expectedExceptions = VerifyException.class, expectedExceptionsMessageRegExp = "All consumed dynamic filters could not be matched with a join.") | ||
| public void testUnmatchedDynamicFilter() | ||
| { | ||
| PlanNode root = builder.output( | ||
| ImmutableList.of(), | ||
| ImmutableList.of(), | ||
| builder.join( | ||
| INNER, | ||
| ordersTableScanNode, | ||
| builder.filter( | ||
| logicalRowExpressions.combineConjuncts( | ||
| builder.rowExpression("LINEITEM_OK > 0"), | ||
| createDynamicFilterExpression("DF", lineitemOrderKeyVariable, metadata.getFunctionManager())), | ||
| lineitemTableScanNode), | ||
| ImmutableList.of(new JoinNode.EquiJoinClause(ordersOrderKeyVariable, lineitemOrderKeyVariable)), | ||
| ImmutableList.of(ordersOrderKeyVariable), | ||
| Optional.empty(), | ||
| Optional.empty(), | ||
| Optional.empty(), | ||
| ImmutableMap.of())); | ||
| validatePlan(root); | ||
| } | ||
|
|
||
| @Test(expectedExceptions = VerifyException.class, expectedExceptionsMessageRegExp = "All consumed dynamic filters could not be matched with a join.") | ||
| public void testUnmatchedNestedDynamicFilter() | ||
| { | ||
| PlanNode root = builder.output( | ||
| ImmutableList.of(), | ||
| ImmutableList.of(), | ||
| builder.join( | ||
| INNER, | ||
| ordersTableScanNode, | ||
| builder.filter( | ||
| logicalRowExpressions.combineConjuncts( | ||
| logicalRowExpressions.combineDisjuncts( | ||
| builder.rowExpression("LINEITEM_OK IS NULL"), | ||
| createDynamicFilterExpression("DF", lineitemOrderKeyVariable, metadata.getFunctionManager())), | ||
| logicalRowExpressions.combineDisjuncts( | ||
| builder.rowExpression("LINEITEM_OK IS NOT NULL"), | ||
| createDynamicFilterExpression("DF", lineitemOrderKeyVariable, metadata.getFunctionManager()))), | ||
| lineitemTableScanNode), | ||
| ImmutableList.of(new JoinNode.EquiJoinClause(ordersOrderKeyVariable, lineitemOrderKeyVariable)), | ||
| ImmutableList.of(ordersOrderKeyVariable), | ||
| Optional.empty(), | ||
| Optional.empty(), | ||
| Optional.empty(), | ||
| ImmutableMap.of())); | ||
| validatePlan(root); | ||
| } | ||
|
|
||
| private void validatePlan(PlanNode root) | ||
| { | ||
| getQueryRunner().inTransaction(session -> { | ||
| // metadata.getCatalogHandle() registers the catalog for the transaction | ||
| session.getCatalog().ifPresent(catalog -> metadata.getCatalogHandle(session, catalog)); | ||
| new DynamicFiltersChecker().validate(root, session, metadata, new SqlParser(), TypeProvider.empty(), WarningCollector.NOOP); | ||
| return null; | ||
| }); | ||
| } | ||
| } |