[native] Add decimal data test for checksum

prestodb · Oct 26, 2023 · a00fdc6 · a00fdc6
1 parent d4d3ad6
commit a00fdc6
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/presto-native-execution/presto_cpp/main/tests/PrestoQueryRunnerTest.cpp b/presto-native-execution/presto_cpp/main/tests/PrestoQueryRunnerTest.cpp
@@ -87,7 +87,8 @@ TEST_F(PrestoQueryRunnerTest, DISABLED_fuzzer) {
 
   auto veloxResults =
       velox::exec::test::AssertQueryBuilder(plan).copyResults(pool());
-  velox::exec::test::assertEqualResults(prestoResults, {veloxResults});
+  velox::exec::test::assertEqualResults(
+      prestoResults, plan->outputType(), {veloxResults});
 }
 
 } // namespace facebook::presto::test

diff --git a/...cution/src/test/java/com/facebook/presto/nativeworker/AbstractTestNativeAggregations.java b/...cution/src/test/java/com/facebook/presto/nativeworker/AbstractTestNativeAggregations.java
@@ -302,6 +302,12 @@ public void testChecksum()
         assertQuery("SELECT checksum(quantity_by_linenumber) FROM orders_ex");
         assertQuery("SELECT shipmode, checksum(extendedprice) FROM lineitem GROUP BY shipmode");
         assertQuery("SELECT checksum(from_unixtime(orderkey, '+01:00')) FROM lineitem WHERE orderkey < 20");
+
+        // test DECIMAL data
+        assertQuery("SELECT checksum(a), checksum(b) FROM (VALUES (DECIMAL '1.234', DECIMAL '611180549424.4633133')) AS t(a, b)");
+        assertQuery("SELECT checksum(a), checksum(b) FROM (VALUES (DECIMAL '1.234', DECIMAL '611180549424.4633133'), (NULL, NULL)) AS t(a, b)");
+        assertQuery("SELECT checksum(a), checksum(b) FROM (VALUES (DECIMAL '1.234', CAST('2343331593029422743' AS DECIMAL(38, 0))), (CAST('999999999999999999' AS DECIMAL(18, 0)), CAST('99999999999999999999999999999999999999' AS DECIMAL(38, 0)))) AS t(a, b)");
+        assertQuery("SELECT checksum(a), checksum(b) FROM (VALUES (CAST('999999999999999999' AS DECIMAL(18, 0)), CAST('99999999999999999999999999999999999999' AS DECIMAL(38, 0))), (CAST('-999999999999999999' as DECIMAL(18, 0)), CAST('-99999999999999999999999999999999999999' AS DECIMAL(38, 0)))) AS t(a, b)");
     }
 
     @Test

diff --git a/presto-native-execution/velox b/presto-native-execution/velox