Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ALTER FUNCTION #13799

Merged
merged 3 commits into from
Jan 14, 2020
Merged

Support ALTER FUNCTION #13799

merged 3 commits into from
Jan 14, 2020

Conversation

caithagoras
Copy link
Contributor

@caithagoras caithagoras commented Dec 4, 2019 •
edited
Loading

ALTER FUNCTION Syntax:

<alter routine statement> ::=
    ALTER <specific routine designator> <alter routine characteristics>

<specific routine designator> ::=
    <routine type> <member name>

<routine type> ::=
    FUNCTION

<member name> ::=
    <schema qualified routine name> [ <data type list> ]

<alter routine characteristic> ::=
    <null-call clause>

== RELEASE NOTES ==

General Changes
* Add support for ``ALTER FUNCTION``.

@caithagoras caithagoras changed the title S1 @caithagoras Support ALTER FUNCTION c47c714 Dec 4, 2019
@caithagoras caithagoras changed the title @caithagoras Support ALTER FUNCTION c47c714 Support ALTER FUNCTION Dec 4, 2019
@caithagoras caithagoras changed the title Support ALTER FUNCTION [WIP] Support ALTER FUNCTION Dec 4, 2019
@caithagoras caithagoras force-pushed the s1 branch 3 times, most recently from 01e807b to 942e553 Compare December 4, 2019 03:29
@caithagoras caithagoras changed the title [WIP] Support ALTER FUNCTION Support ALTER FUNCTION Dec 4, 2019
@caithagoras caithagoras requested a review from rongrong December 4, 2019 03:29
@caithagoras caithagoras changed the title Support ALTER FUNCTION [WIP] Support ALTER FUNCTION Dec 4, 2019
@caithagoras caithagoras removed the request for review from rongrong December 4, 2019 03:41
@caithagoras caithagoras force-pushed the s1 branch 7 times, most recently from ab681cd to 713aeb6 Compare December 10, 2019 01:46
@caithagoras caithagoras changed the title [WIP] Support ALTER FUNCTION Support ALTER FUNCTION Dec 10, 2019
@caithagoras caithagoras requested a review from rongrong December 10, 2019 01:47
@caithagoras caithagoras force-pushed the s1 branch 4 times, most recently from f99591d to da2376c Compare December 10, 2019 01:56
@rongrong rongrong requested a review from kaikalur December 11, 2019 23:51
@rongrong
Copy link
Contributor

@kaikalur can you take a look at the syntax? Thanks!

@caithagoras caithagoras force-pushed the s1 branch 2 times, most recently from 3d617bc to bd76c5d Compare December 12, 2019 19:52
@rongrong
Copy link
Contributor

Mostly nits.

@caithagoras caithagoras force-pushed the s1 branch 5 times, most recently from 3433357 to 4355c2e Compare December 17, 2019 08:31
rongrong
rongrong approved these changes Jan 10, 2020
View reviewed changes
Copy link
Contributor

@rongrong rongrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just some thoughts to consider.

presto-parser/src/main/java/com/facebook/presto/sql/SqlFormatter.java Outdated Show resolved Hide resolved
presto-main/src/main/java/com/facebook/presto/metadata/BuiltInFunctionNamespaceManager.java Show resolved Hide resolved
@caithagoras caithagoras force-pushed the s1 branch 2 times, most recently from 05d4ba7 to cea0f07 Compare January 14, 2020 20:38
@caithagoras0
Support ALTER FUNCTION
9a19736 
Also, use an existing function to test drop function in
TestSqlFunctions.
@rongrong rongrong merged commit 386164e into prestodb:master Jan 14, 2020
@caithagoras caithagoras deleted the s1 branch January 14, 2020 22:40
@martint martint mentioned this pull request Jan 30, 2020
Closed
9 tasks
@caithagoras caithagoras mentioned this pull request Feb 20, 2020
Merged
8 tasks
@JiajunBernoulli JiajunBernoulli mentioned this pull request Oct 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaikalur kaikalur kaikalur left review comments

@rongrong rongrong rongrong approved these changes

Assignees

@rongrong rongrong

@kaikalur kaikalur

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@caithagoras @rongrong @kaikalur @caithagoras0