Improve error handling during determinism analysis #15056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We rerun control queries first and then the limit query analysis, In one case, we see a determinism analysis failed because the control rerun failed due to a transient generic internal error. The query contains a LIMIT clause, but limit query analysis was never run as the exception is caught and the analysis is marked as ANALYSIS_FAILED_QUERY_FAILURE. To mitigate this issue: - Run limit query analysis before control reruns, since it is a light-weight analysis. - If analysis query is failing during limit query analysis, do not return and proceed to the control reruns.
|
cc @mbasmanova for committer approval. Thanks! |
|
cc @wenleix @rschlussel Can you take final look since @ajaygeorge has already reviewed the diff? Thanks! |
rschlussel
approved these changes
Aug 25, 2020
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We rerun control queries first and then the limit query analysis,
In one case, we see a determinism analysis failed because the control
rerun failed due to a transient generic internal error. The query
contains a LIMIT clause, but limit query analysis was never run as
the exception is caught and the analysis is marked as
ANALYSIS_FAILED_QUERY_FAILURE.
To mitigate this issue:
light-weight analysis.
not return and proceed to the control reruns.