Fix incorrect intersection between two envelopes #15104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When two envelopes intersected at a single point, the intersection would be incorrectly calculated as `POINT(x, x)` instead of `POINT(x, y)`. This also simplifies the logic when two envelopes intersect in a line.
|
cc: @mbasmanova Correctness fix for |
mbasmanova
approved these changes
Sep 8, 2020
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When two envelopes intersected at a single point, the intersection would
be incorrectly calculated as
POINT(x, x)instead ofPOINT(x, y).This also simplifies the logic when two envelopes intersect in a line.
Test plan - Added unit test for failing case.