Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH Actions] Clear unused disk space #21000

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

ZacBlanco
Copy link
Contributor

@ZacBlanco ZacBlanco commented Sep 29, 2023

Description

Free up some additional space on the runners before executing the product-tests suite. The /opt/hostedtoolcache folder is unnecessary and gives 10GB back in disk space after deleting it. The idea came from this thread: https://github.com/orgs/community/discussions/25678#discussioncomment-5242449. Previously the product test actions would fail with no space left on device when pulling the container images.

Below is the runner output from the Free Disk Space step:

df -h
  sudo apt-get clean
  rm -rf /opt/hostedtoolcache
  df -h
  shell: /usr/bin/bash -e {0}
  env:
    CONTINUOUS_INTEGRATION: true
    MAVEN_OPTS: -Xmx1024M -XX:+ExitOnOutOfMemoryError
    MAVEN_INSTALL_OPTS: -Xmx2G -XX:+ExitOnOutOfMemoryError
    MAVEN_FAST_INSTALL: -B -V --quiet -T C1 -DskipTests -Dair.check.skip-all -Dmaven.javadoc.skip=true
    RETRY: .github/bin/retry
Filesystem      Size  Used Avail Use% Mounted on
/dev/root        84G   64G   20G  77% /
tmpfs           3.4G  172K  3.4G   1% /dev/shm
tmpfs           1.4G  1.1M  1.4G   1% /run
tmpfs           5.0M     0  5.0M   0% /run/lock
/dev/sda15      105M  6.1M   99M   6% /boot/efi
/dev/sdb1        14G  4.1G  9.0G  31% /mnt
tmpfs           693M   12K  693M   1% /run/user/1001
Filesystem      Size  Used Avail Use% Mounted on
/dev/root        84G   53G   31G  63% /
tmpfs           3.4G  172K  3.4G   1% /dev/shm
tmpfs           1.4G  1.1M  1.4G   1% /run
tmpfs           5.0M     0  5.0M   0% /run/lock
/dev/sda15      105M  6.1M   99M   6% /boot/efi
/dev/sdb1        14G  4.1G  9.0G  31% /mnt
tmpfs           693M   12K  693M   1% /run/user/1001

Motivation and Context

N/A

Impact

N/A

Test Plan

N/A

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

== NO RELEASE NOTE ==

@ZacBlanco ZacBlanco requested a review from a team as a code owner September 29, 2023 21:35
@ZacBlanco ZacBlanco force-pushed the upstream-action-product-tests branch from fbed816 to 0ae1b8e Compare September 29, 2023 21:45
@ZacBlanco ZacBlanco requested a review from tdcmeehan September 29, 2023 21:45
@ZacBlanco ZacBlanco changed the title [GH Actions] Attempt to clear unused disk space [GH Actions] Clear unused disk space Sep 29, 2023
@ZacBlanco
Copy link
Contributor Author

@tdcmeehan Thoughts compared to your other PR? This one seems to be more of a bandaid solution for the time being.

@tdcmeehan
Copy link
Contributor

@tdcmeehan Thoughts compared to your other PR? This one seems to be more of a bandaid solution for the time being.

My other PR isn't effective at the disk space issue (might reduce latency).

Copy link
Contributor

@tdcmeehan tdcmeehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tdcmeehan tdcmeehan merged commit 0a5b526 into prestodb:master Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants