Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pinot connector] Fix pinot single quote literal push down issue #21020

Merged

Conversation

xiangfu0
Copy link
Contributor

@xiangfu0 xiangfu0 commented Oct 3, 2023

Description

When pushing down literal expression to pinot, single quote is not escaped.
Fix the issue by replacing single quote to two single quotes in a query.

Test Plan

Unit test with predicate

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

Pinot Changes
*  Fix pinot single quote literal push down issue

@xiangfu0 xiangfu0 requested a review from a team as a code owner October 3, 2023 03:34
@xiangfu0 xiangfu0 requested a review from presto-oss October 3, 2023 03:34
@tdcmeehan tdcmeehan self-assigned this Oct 3, 2023
@ajaygeorge
Copy link
Contributor

@xiangfu0
Copy link
Contributor Author

xiangfu0 commented Oct 4, 2023

A small nit wrt commit message. fixing -> Fix https://github.com/prestodb/presto/wiki/Review-and-Commit-guidelines#commit-formatting-and-pull-requests

thanks! done

@xiangfu0 xiangfu0 changed the title [pinot connector] fixing pinot single quote literal push down issue [pinot connector] Fix pinot single quote literal push down issue Oct 4, 2023
@xiangfu0
Copy link
Contributor Author

xiangfu0 commented Oct 9, 2023

Hi,

just checking if there is anything else needs to change.

Thanks a lot for taking the time to review and approve it!

@tdcmeehan tdcmeehan merged commit a23819a into prestodb:master Oct 9, 2023
@xiangfu0 xiangfu0 deleted the fixing_pinot_literal_single_quote branch October 23, 2023 18:17
@wanglinsong wanglinsong mentioned this pull request Dec 8, 2023
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants