[Native] Trim native prefix for system session property #21023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaoxmeng
reviewed
Oct 3, 2023
presto-main/src/main/java/com/facebook/presto/SystemSessionProperties.java
Outdated
Show resolved
Hide resolved
kewang1024
force-pushed
the
trim-native-prefix
branch
from
95635b7 to
62de48e
Compare
xiaoxmeng
reviewed
Oct 3, 2023
presto-native-execution/presto_cpp/main/QueryContextManager.cpp
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/com/facebook/presto/SystemSessionProperties.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/com/facebook/presto/SystemSessionProperties.java
Outdated
Show resolved
Hide resolved
presto-native-execution/presto_cpp/main/tests/QueryContextManagerTest.cpp
Outdated
Show resolved
Hide resolved
presto-native-execution/presto_cpp/main/QueryContextManager.cpp
Outdated
Show resolved
Hide resolved
kewang1024
force-pushed
the
trim-native-prefix
branch
3 times, most recently
from
7877ec1 to
b97575e
Compare
xiaoxmeng
approved these changes
Oct 3, 2023
There was a problem hiding this comment.
@kewang1024 LGTM. Can you check with @amitkdutta as we might need to update our internal job setup with the changed session properties. Thanks!
presto-native-execution/presto_cpp/main/QueryContextManager.cpp
Outdated
Show resolved
Hide resolved
presto-native-execution/presto_cpp/main/QueryContextManager.cpp
Outdated
Show resolved
Hide resolved
presto-native-execution/presto_cpp/main/QueryContextManager.cpp
Outdated
Show resolved
Hide resolved
presto-native-execution/presto_cpp/main/QueryContextManager.cpp
Outdated
Show resolved
Hide resolved
presto-native-execution/presto_cpp/main/tests/QueryContextManagerTest.cpp
Outdated
Show resolved
Hide resolved
presto-native-execution/presto_cpp/main/tests/QueryContextManagerTest.cpp
Outdated
Show resolved
Hide resolved
presto-native-execution/presto_cpp/main/tests/QueryContextManagerTest.cpp
Outdated
Show resolved
Hide resolved
kewang1024
force-pushed
the
trim-native-prefix
branch
from
b97575e to
46de7ee
Compare
amitkdutta
reviewed
Oct 3, 2023
| @@ -51,13 +51,23 @@ folly::IOThreadPoolExecutor* spillExecutorPtr() { | |||
| } | |||
|
|
|||
| namespace { | |||
| std::string maybeRemoveNativePrefix(const std::string& name) { | |||
| static const std::string kNativePrefix = "native_"; | |||
| const auto result = | |||
There was a problem hiding this comment.
Will it work with old coordinator where native prefix is not passed? We can keep the worker backward compatible so that it can work with native and without native prefixed properties. Once coordinator is updated, we can remove anything that does not have native prefix.
There was a problem hiding this comment.
I think it will work if old coordinator doesn't pass native prefix.
There was a problem hiding this comment.
Nice. Then lets just enhance the unit test to keep the legacy case. Once coordinator is updated, we can remove it.
There was a problem hiding this comment.
Yes, it will work with old coordinator
|
@kewang1024 Lets keep the worker compatible with old coordinator. |
amitkdutta
requested changes
Oct 3, 2023
presto-native-execution/presto_cpp/main/tests/QueryContextManagerTest.cpp
Show resolved
Hide resolved
kewang1024
force-pushed
the
trim-native-prefix
branch
from
46de7ee to
d307d4f
Compare
kewang1024
force-pushed
the
trim-native-prefix
branch
from
d307d4f to
5babfc1
Compare
amitkdutta
approved these changes
Oct 4, 2023
NikhilCollooru
approved these changes
Oct 4, 2023
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add writer_native_spill_enabled session property.